Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS: Assorted QuickInfo improvements #14933

Merged
merged 7 commits into from
Mar 20, 2023

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Mar 20, 2023

Replace awful ASCII art separator with something more subtle and align icon to top:
image

Use the built-in nav link functionality that VS now provides, instead of custom. Restore the little tooltip with file name that once was there IIRC.

That was a low hanging fruit. Here are a few more involved things that come to my mind to do as a follow up:

  • Render QuickInfo parts in proper order, i.e. icon -> description -> documentation for each ToolTipElement the service provides.
  • Provide option to use monospaced / programming font for the main description.
  • Expose option to set width: Add optional width parameter to GetToolTip #14891
  • Use JoinableTaskFactory and allow user to cancel the hyperlink navigation: There are two codepaths in link navigation, one is instant as it just goes to the range of symbol, the other one is smart but slower as it looks up the implementation. Provide an option to fallback to fast track when the user cancels.
  • Do "find usages" on link click, when we are at the symbol definition already (like C# does it).

@majocha majocha requested a review from a team as a code owner March 20, 2023 09:11
@T-Gro
Copy link
Member

T-Gro commented Mar 20, 2023

How would the find usages on link click work?
Open the Find References panel and show them here, as if you triggered a search manually?

Co-authored-by: Adam Boniecki <20281641+abonie@users.noreply.github.com>
@majocha
Copy link
Contributor Author

majocha commented Mar 20, 2023

How would the find usages on link click work? Open the Find References panel and show them here, as if you triggered a search manually?

Ah, I thought I saw this working in a C# project, but can't get it to work now. Yes it just launched the panel for the symbol.
What we do instead is we don't show the link at all if QuickInfo is triggered on a point of definition.
Alternative that came on my mind right now is to make the link go to signature and vice versa, just like F12 works now.

@vzarytovskii vzarytovskii merged commit 3e00675 into dotnet:main Mar 20, 2023
@majocha majocha deleted the quickinfo-separator branch March 23, 2023 08:04
kant2002 pushed a commit to kant2002/fsharp that referenced this pull request Apr 1, 2023
Co-authored-by: Adam Boniecki <20281641+abonie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants