VS checkbox for controlling the "Remove parens" diag+fix (#16211)

* Editor option around the remove parens codefix

Author: T-Gro

vsintegration/src/FSharp.Editor/Diagnostics/DocumentDiagnosticAnalyzer.fs

@@ -110,8 +110,9 @@ type internal FSharpDocumentDiagnosticAnalyzer [<ImportingConstructor>] () =
 
             let! unnecessaryParentheses =
                 match diagnosticType with
-                | DiagnosticsType.Semantic -> CancellableTask.singleton ImmutableArray.Empty
-                | DiagnosticsType.Syntax -> UnnecessaryParenthesesDiagnosticAnalyzer.GetDiagnostics document
+                | DiagnosticsType.Syntax when document.Project.IsFsharpRemoveParensEnabled ->
+                    UnnecessaryParenthesesDiagnosticAnalyzer.GetDiagnostics document
+                | _ -> CancellableTask.singleton ImmutableArray.Empty
 
             if errors.Count = 0 && unnecessaryParentheses.IsEmpty then
                 return ImmutableArray.Empty

vsintegration/src/FSharp.Editor/Options/EditorOptions.fs

@@ -63,6 +63,7 @@ type CodeFixesOptions =
         UnusedOpens: bool
         UnusedDeclarations: bool
         SuggestNamesForErrors: bool
+        RemoveParens: bool
     }
 
     static member Default =
@@ -73,6 +74,7 @@ type CodeFixesOptions =
             UnusedOpens = true
             UnusedDeclarations = true
             SuggestNamesForErrors = true
+            RemoveParens = false
         }
 
 [<CLIMutable>]
@@ -250,6 +252,8 @@ module EditorOptionsExtensions =
         member this.IsFSharpCodeFixesUnusedOpensEnabled =
             this.EditorOptions.CodeFixes.UnusedOpens
 
+        member this.IsFsharpRemoveParensEnabled = this.EditorOptions.CodeFixes.RemoveParens
+
         member this.IsFSharpCodeFixesSuggestNamesForErrorsEnabled =
             this.EditorOptions.CodeFixes.SuggestNamesForErrors
 

vsintegration/src/FSharp.UIResources/CodeFixesOptionControl.xaml

@@ -31,6 +31,8 @@
 
                         <CheckBox x:Name="suggestNamesForErrors" IsChecked="{Binding SuggestNamesForErrors}"
                                   Content="{x:Static local:Strings.Suggest_names_for_errors_code_fix}"/>
+                        <CheckBox x:Name="removeParens" IsChecked="{Binding RemoveParens}"
+                                  Content="{x:Static local:Strings.Remove_parens_code_fix}"/>
                     </StackPanel>
                 </GroupBox>
             </StackPanel>

vsintegration/src/FSharp.UIResources/Strings.Designer.cs

@@ -285,4 +285,7 @@
   <data name="Background_analysis" xml:space="preserve">
     <value>Background analysis</value>
   </data>
+  <data name="Remove_parens_code_fix" xml:space="preserve">
+    <value>Remove unnecessary parentheses (experimental, might affect typing performance)</value>
+  </data>
 </root>