Skip to content

Commit c97ca98

Browse files
committed
Only add attribute to module when module declaration has attribute.
1 parent 82e5d0f commit c97ca98

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

src/Compiler/Checking/CheckDeclarations.fs

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -961,8 +961,7 @@ module MutRecBindingChecking =
961961
tryAddExtensionAttributeIfNotAlreadyPresent
962962
(fun tryFindExtensionAttribute ->
963963
tycon.MembersOfFSharpTyconSorted
964-
|> Seq.choose (fun m -> tryFindExtensionAttribute m.Attribs)
965-
|> Seq.tryHead
964+
|> Seq.tryPick (fun m -> tryFindExtensionAttribute m.Attribs)
966965
)
967966
tycon
968967
)
@@ -4232,8 +4231,7 @@ module TcDeclarations =
42324231
tryAddExtensionAttributeIfNotAlreadyPresent
42334232
(fun tryFindExtensionAttribute ->
42344233
tycon.MembersOfFSharpTyconSorted
4235-
|> Seq.choose (fun m -> tryFindExtensionAttribute m.Attribs)
4236-
|> Seq.tryHead
4234+
|> Seq.tryPick (fun m -> tryFindExtensionAttribute m.Attribs)
42374235
)
42384236
tycon
42394237
MutRecShape.Tycon (Some tycon, bindings)
@@ -4242,8 +4240,8 @@ module TcDeclarations =
42424240
tryAddExtensionAttributeIfNotAlreadyPresent
42434241
(fun tryFindExtensionAttribute ->
42444242
moduleOrNamespaceType.Value.AllValsAndMembers
4245-
|> Seq.choose (fun v -> tryFindExtensionAttribute v.Attribs)
4246-
|> Seq.tryHead
4243+
|> Seq.filter(fun v -> v.IsModuleBinding)
4244+
|> Seq.tryPick (fun v -> tryFindExtensionAttribute v.Attribs)
42474245
)
42484246
entity
42494247

@@ -4800,11 +4798,10 @@ let rec TcModuleOrNamespaceElementNonMutRec (cenv: cenv) parent typeNames scopem
48004798
match moduleContents with
48014799
| ModuleOrNamespaceContents.TMDefs(defs) ->
48024800
defs
4803-
|> Seq.choose (function
4801+
|> Seq.tryPick (function
48044802
| ModuleOrNamespaceContents.TMDefLet (Binding.TBind(var = v),_) ->
48054803
tryFindExtensionAttribute v.Attribs
48064804
| _ -> None)
4807-
|> Seq.tryHead
48084805
| _ -> None
48094806
)
48104807
moduleEntity

0 commit comments

Comments
 (0)