Fix access checking for properies setters in attribute arguments (#18581)

Author: evgTSV

src/Compiler/Checking/Expressions/CheckExpressions.fs

@@ -11399,7 +11399,12 @@ and TcAttributeEx canFail (cenv: cenv) (env: TcEnv) attrTgt attrEx (synAttr: Syn
 
                 let mkAttribExpr e =
                     AttribExpr(e, EvalLiteralExprOrAttribArg g e)
-
+                    
+                let checkPropSetterAttribAccess m (pinfo: PropInfo) =
+                    let setterMeth = pinfo.SetterMethod
+                    if not <| IsTypeAndMethInfoAccessible cenv.amap m ad ad setterMeth then
+                        errorR(Error (FSComp.SR.tcPropertyCannotBeSetPrivateSetter(pinfo.PropertyName), m))                       
+                        
                 let namedAttribArgMap =
                   attributeAssignedNamedItems |> List.map (fun (CallerNamedArg(id, CallerArg(callerArgTy, m, isOpt, callerArgExpr))) ->
                     if isOpt then error(Error(FSComp.SR.tcOptionalArgumentsCannotBeUsedInCustomAttribute(), m))
@@ -11411,6 +11416,7 @@ and TcAttributeEx canFail (cenv: cenv) (env: TcEnv) attrTgt attrEx (synAttr: Syn
                       | Item.Property (info = [pinfo]) ->
                           if not pinfo.HasSetter then
                             errorR(Error(FSComp.SR.tcPropertyCannotBeSet0(), m))
+                          checkPropSetterAttribAccess m pinfo
                           id.idText, true, pinfo.GetPropertyType(cenv.amap, m)
                       | Item.ILField finfo ->
                           CheckILFieldInfoAccessible g cenv.amap m ad finfo

src/Compiler/FSComp.txt

@@ -1526,6 +1526,7 @@ notAFunctionButMaybeDeclaration,"This value is not a function and cannot be appl
 3245,tcCopyAndUpdateNeedsRecordType,"The input to a copy-and-update expression that creates an anonymous record must be either an anonymous record or a record"
 3246,tcAugmentationsCannotHaveAttributes,"Attributes cannot be applied to type extensions."
 3247,couldNotLoadDependencyManagerExtension,"The dependency manager extension %s could not be loaded. Message: %s"
+3248,tcPropertyCannotBeSetPrivateSetter,"Property '%s' cannot be set because the setter is private"
 3250,expressionHasNoName,"Expression does not have a name."
 3251,chkNoFirstClassNameOf,"Using the 'nameof' operator as a first-class function value is not permitted."
 3252,tcIllegalByrefsInOpenTypeDeclaration,"Byref types are not allowed in an open type declaration."

src/Compiler/xlf/FSComp.txt.cs.xlf

@@ -0,0 +1,51 @@
+namespace FSharp.Compiler.ComponentTests.Attributes
+
+open Xunit
+open FSharp.Test.Compiler
+
+module AttributeCtorSetPropAccess =
+    let private csLib = """
+    using System;
+
+    namespace TestAttribute
+    {
+        [AttributeUsage(AttributeTargets.All, Inherited = false)]
+        public class FooAttribute : Attribute
+        {
+            public int X { get; %s set; }
+        }
+    }
+    """
+
+    let private fsCode = """
+    namespace Other
+    open System
+    open TestAttribute
+    
+    module TestAttributeModule =
+
+        [<FooAttribute(X = 100)>]
+        let myFunction() = ()
+    """
+
+    [<Theory>]
+    [<InlineData("private")>]
+    [<InlineData("internal")>]
+    [<InlineData("protected")>]
+    [<InlineData("private protected")>]
+    [<InlineData("protected internal")>]
+    let ``Cannot set property outside its accessibility scope``(modifier: string): unit =
+        FSharp fsCode 
+        |> withReferences [(CSharp <| csLib.Replace("%s", modifier))] 
+        |> compile 
+        |> shouldFail
+        |> withDiagnostics [ (ErrorType.Error 3248, Line 8, Col 28, Line 8, Col 31, "Property 'X' cannot be set because the setter is private") ] 
+        |> ignore
+
+    [<Fact>]
+    let ``Can set property inside its accessibility scope``(): unit =
+        FSharp fsCode 
+        |> withReferences [(CSharp <| csLib.Replace("%s", ""))] 
+        |> compile 
+        |> shouldSucceed
+        |> ignore

src/Compiler/xlf/FSComp.txt.de.xlf

@@ -345,6 +345,7 @@
     <Compile Include="FSharpChecker\TransparentCompiler.fs" />
     <Compile Include="FSharpChecker\SymbolUse.fs" />
     <Compile Include="FSharpChecker\FindReferences.fs" />
+    <Compile Include="Attributes\AttributeCtorSetPropAccess.fs"/>
   </ItemGroup>
 
   <ItemGroup>