Merge pull request #9707 from dotnet/merges/master-to-release/dev16.8

Merge master to release/dev16.8

Author: brettfo

src/fsharp/FSharp.Core/reflect.fs

@@ -166,9 +166,9 @@ module internal Impl =
                         let nm = minfo.Name
                         // chop "get_" or  "New" off the front
                         let nm =
-                            if not (isListType typ) && not (isOptionType typ) then
-                                if   nm.Length > 4 && nm.[0..3] = "get_" then nm.[4..]
-                                elif nm.Length > 3 && nm.[0..2] = "New" then nm.[3..]
+                            if not (isListType typ) && not (isOptionType typ) && nm.Length > 3 then
+                                if   nm.StartsWith ("get_", StringComparison.Ordinal) then nm.[4..]
+                                elif nm.StartsWith ("New", StringComparison.Ordinal) then nm.[3..]
                                 else nm
                             else nm
                         Some (n, nm)

src/fsharp/service/FSharpCheckerResults.fsi

@@ -235,11 +235,11 @@ type public FSharpCheckFileResults =
     /// Find the most precise display environment for the given line and column.
     member GetDisplayContextForPos : pos : pos -> Async<FSharpDisplayContext option>
 
-    /// Determines if a long ident is resolvable at a specific point.
+    /// <summary>Determines if a long ident is resolvable at a specific point.</summary>
     /// <param name="userOpName">An optional string used for tracing compiler operations associated with this request.</param>
     member internal IsRelativeNameResolvable: cursorPos : pos * plid : string list * item: Item * ?userOpName: string -> Async<bool>
 
-    /// Determines if a long ident is resolvable at a specific point.
+    /// <summary>Determines if a long ident is resolvable at a specific point.</summary>
     /// <param name="userOpName">An optional string used for tracing compiler operations associated with this request.</param>
     member IsRelativeNameResolvableFromSymbol: cursorPos : pos * plid : string list * symbol: FSharpSymbol * ?userOpName: string -> Async<bool>
 
@@ -399,4 +399,4 @@ type internal FsiInteractiveChecker =
 module internal FSharpCheckerResultsSettings =
     val defaultFSharpBinariesDir: string
 
-    val maxTimeShareMilliseconds : int64
+    val maxTimeShareMilliseconds : int64