Skip to content

Commit 0964431

Browse files
authored
Update legacymsbuildreferenceresolver to support net48 (#9776)
* Update legacyresolver to support net48 * Missed bits
1 parent 7ae37f1 commit 0964431

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

src/fsharp/LegacyMSBuildReferenceResolver.fs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,10 @@ module LegacyMSBuildReferenceResolver
7373
[<Literal>]
7474
let private Net472 = "v4.7.2"
7575

76-
let SupportedDesktopFrameworkVersions = [ Net472; Net471; Net47; Net462; Net461; Net46; Net452; Net451; Net45 ]
76+
[<Literal>]
77+
let private Net48 = "v4.8"
78+
79+
let SupportedDesktopFrameworkVersions = [ Net48; Net472; Net471; Net47; Net462; Net461; Net46; Net452; Net451; Net45 ]
7780

7881
/// Get the path to the .NET Framework implementation assemblies by using ToolLocationHelper.GetPathToDotNetFramework
7982
/// This is only used to specify the "last resort" path for assembly resolution.
@@ -90,6 +93,7 @@ module LegacyMSBuildReferenceResolver
9093
| Net47 -> Some TargetDotNetFrameworkVersion.Version47
9194
| Net471 -> Some TargetDotNetFrameworkVersion.Version471
9295
| Net472 -> Some TargetDotNetFrameworkVersion.Version472
96+
| Net48 -> Some TargetDotNetFrameworkVersion.Version48
9397
#endif
9498
| _ -> assert false; None
9599
match v with
@@ -116,7 +120,8 @@ module LegacyMSBuildReferenceResolver
116120
try
117121
// The Mono build still uses an ancient version of msbuild from around Dev 14
118122
#if MSBUILD_AT_LEAST_15
119-
if box (ToolLocationHelper.GetPathToDotNetFramework(TargetDotNetFrameworkVersion.Version472)) <> null then Net472
123+
if box (ToolLocationHelper.GetPathToDotNetFramework(TargetDotNetFrameworkVersion.Version48)) <> null then Net48
124+
elif box (ToolLocationHelper.GetPathToDotNetFramework(TargetDotNetFrameworkVersion.Version472)) <> null then Net472
120125
elif box (ToolLocationHelper.GetPathToDotNetFramework(TargetDotNetFrameworkVersion.Version471)) <> null then Net471
121126
elif box (ToolLocationHelper.GetPathToDotNetFramework(TargetDotNetFrameworkVersion.Version47)) <> null then Net47
122127
elif box (ToolLocationHelper.GetPathToDotNetFramework(TargetDotNetFrameworkVersion.Version462)) <> null then Net462

src/utils/reshapedmsbuild.fs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,8 @@ module internal MsBuildAdapters =
9393
| Version47 = 11
9494
| Version471 = 12
9595
| Version472 = 13
96-
| VersionLatest = 13 //TargetDotNetFrameworkVersion.Version472
96+
| Version48 = 14
97+
| VersionLatest = 14 //TargetDotNetFrameworkVersion.Version48
9798

9899
/// <summary>
99100
/// Used to specify the targeted bitness of the .NET Framework for some methods of ToolLocationHelper
@@ -126,6 +127,7 @@ module internal ToolLocationHelper =
126127
let dotNetFrameworkVersion47 = Version(4, 7)
127128
let dotNetFrameworkVersion471 = Version(4, 7, 1)
128129
let dotNetFrameworkVersion472 = Version(4, 7, 2)
130+
let dotNetFrameworkVersion48 = Version(4, 8)
129131

130132
// visual studio versions.
131133
let visualStudioVersion100 = new Version(10, 0);
@@ -221,6 +223,7 @@ module internal ToolLocationHelper =
221223
| TargetDotNetFrameworkVersion.Version47 -> dotNetFrameworkVersion47
222224
| TargetDotNetFrameworkVersion.Version471 -> dotNetFrameworkVersion471
223225
| TargetDotNetFrameworkVersion.Version472 -> dotNetFrameworkVersion472
226+
| TargetDotNetFrameworkVersion.Version48 -> dotNetFrameworkVersion48
224227
| _ -> raise (getArgumentException version)
225228

226229
let complusInstallRoot = Environment.GetEnvironmentVariable("COMPLUS_INSTALLROOT")
@@ -764,6 +767,7 @@ module internal ToolLocationHelper =
764767
CreateDotNetFrameworkSpecForV4 dotNetFrameworkVersion47 visualStudioVersion150 // v4.7
765768
CreateDotNetFrameworkSpecForV4 dotNetFrameworkVersion471 visualStudioVersion150 // v4.7.1
766769
CreateDotNetFrameworkSpecForV4 dotNetFrameworkVersion472 visualStudioVersion150 // v4.7.2
770+
CreateDotNetFrameworkSpecForV4 dotNetFrameworkVersion48 visualStudioVersion150 // v4.8
767771
|]
768772
array.ToDictionary<DotNetFrameworkSpec, Version>(fun spec -> spec.Version)
769773

0 commit comments

Comments
 (0)