Fix Assert.Throws to validate parameter names #7007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances test quality and fixes encoding issues across AI-related test files. The changes add parameter name arguments to Assert.Throws calls for better test diagnostics and correct character encoding in test data.
Key changes:
- Added parameter name arguments to
Assert.Throwsassertions across multiple test files for clearer error messages - Fixed character encoding from
�to°for degree symbols in temperature strings - Updated
HostedFileContentconstructor to useThrow.IfNullOrWhitespacefor consistent validation
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SummarizingChatReducerTests.cs | Added parameter names to exception assertions for constructor validation tests |
| MessageCountingChatReducerTests.cs | Added parameter names to exception assertions and fixed degree symbol encoding |
| ToolReductionTests.cs | Added parameter name to ArgumentOutOfRangeException assertion |
| NGramTests.cs | Added parameter names to multiple exception assertions |
| AIJsonUtilitiesTests.cs | Added parameter names to exception assertions for validation tests |
| AIJsonSchemaTransformCacheTests.cs | Added parameter names to exception assertions |
| HostedVectorStoreContentTests.cs | Added parameter names to exception assertions for constructor and property validation |
| HostedFileContentTests.cs | Added parameter names to exception assertions for constructor and property validation |
| HostedFileContent.cs | Updated constructor to use Throw.IfNullOrWhitespace for consistent validation |
shyamnamboodiripad
approved these changes
Nov 3, 2025
This was referenced Nov 11, 2025
Merged
Merged
Merged
Merged
Open
Open
This was referenced Nov 12, 2025
Closed
Merged
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow