Fix coalescing of TextReasoningContent with ProtectedData #6936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the coalescing logic for TextReasoningContent objects that contain ProtectedData. The issue was that when merging consecutive TextReasoningContent items, the ProtectedData from the last item in a merge sequence was not being preserved in the coalesced result.
Key changes:
- Updated the merge factory function to preserve
ProtectedDatafrom the last item in a merge sequence - Added debug assertions to validate merge preconditions
- Added comprehensive test coverage for the new coalescing behavior with
ProtectedData
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ChatResponseExtensions.cs |
Fixed the coalescing logic to preserve ProtectedData from the last item when merging TextReasoningContent, and added debug assertions |
ChatResponseUpdateExtensionsTests.cs |
Added test case verifying correct coalescing behavior when TextReasoningContent items have ProtectedData |
src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatResponseExtensions.cs
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatResponseExtensions.cs
Show resolved
Hide resolved
jeffhandley
approved these changes
Oct 20, 2025
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
I appreciate the Debug.Asserts there.
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Oct 21, 2025
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Oct 21, 2025
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Oct 21, 2025
This was referenced Nov 11, 2025
Merged
Merged
This was referenced Nov 13, 2025
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow