Fix OpenTelemetryChatClient failing on unknown content types #6915
+96
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in OpenTelemetryChatClient where it would fail when encountering unknown or non-serializable AI content types. Instead of throwing exceptions, the client now gracefully handles these cases by attempting to serialize unknown content types and ignoring any that can't be serialized.
Key Changes
- Modified the serialization logic to handle unknown content types gracefully with try-catch protection
- Added support for custom JSON serializer options when processing unknown content types
- Added comprehensive test coverage for the new graceful failure behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Libraries/Microsoft.Extensions.AI/ChatCompletion/OpenTelemetryChatClient.cs | Enhanced SerializeChatMessages method to handle unknown content types gracefully and pass custom serializer options |
| test/Libraries/Microsoft.Extensions.AI.Tests/ChatCompletion/OpenTelemetryChatClientTests.cs | Added test case to verify unknown content types are handled without throwing exceptions |
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/OpenTelemetryChatClient.cs
Show resolved
Hide resolved
test/Libraries/Microsoft.Extensions.AI.Tests/ChatCompletion/OpenTelemetryChatClientTests.cs
Show resolved
Hide resolved
It should fail gracefully by ignoring any content it can't output telemetry for rather than throwing.
stephentoub
force-pushed
the
fixotelexception
branch
from
6b501f5 to
25685eb
Compare
eiriktsarpalis
approved these changes
Oct 13, 2025
joperezr
pushed a commit
to joperezr/extensions
that referenced
this pull request
Oct 14, 2025
…6915) It should fail gracefully by ignoring any content it can't output telemetry for rather than throwing.
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Oct 21, 2025
…6915) It should fail gracefully by ignoring any content it can't output telemetry for rather than throwing.
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Oct 21, 2025
…6915) It should fail gracefully by ignoring any content it can't output telemetry for rather than throwing.
This was referenced Nov 11, 2025
Merged
Merged
Merged
This was referenced Nov 12, 2025
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should fail gracefully by ignoring any content it can't output telemetry for rather than throwing.
Microsoft Reviewers: Open in CodeFlow