Skip to content

Conversation

@KeterSCP
Copy link
Contributor

@KeterSCP KeterSCP commented Oct 1, 2025

Fixes #6832

I cannot run tests locally because of #6463

Microsoft Reviewers: Open in CodeFlow

Copilot AI review requested due to automatic review settings October 1, 2025 19:43
@KeterSCP KeterSCP requested a review from a team as a code owner October 1, 2025 19:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the cgroup v2 drive format check to account for a change in .NET 10 where the drive format string for cgroup2 filesystems changed from "cgroup2fs" to "cgroup2". The change uses conditional compilation directives to maintain backward compatibility.

Key changes:

  • Updates the CgroupVersion constant to use different values based on .NET version
  • Uses conditional compilation to target .NET 10+ vs earlier versions

@cdemi
Copy link

cdemi commented Nov 12, 2025

@amadeuszl .NET 10 is now GA and it's blocking upgrade for everyone using Microsoft.Extensions.Diagnostics.ResourceMonitoring with the official mcr.microsoft.com/dotnet/aspnet:10.0

Can we get feedback on this PR or get this merged?

@amadeuszl amadeuszl merged commit 30d910f into dotnet:main Nov 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft.Extensions.Diagnostics.ResourceMonitoring can not work in .net 10 cgroups v2

3 participants