Skip to content

Conversation

@shyamnamboodiripad
Copy link
Contributor

@shyamnamboodiripad shyamnamboodiripad commented Aug 15, 2025

Microsoft Reviewers: Open in CodeFlow

Copilot AI review requested due to automatic review settings August 15, 2025 05:00
@shyamnamboodiripad shyamnamboodiripad requested a review from a team as a code owner August 15, 2025 05:00
@github-actions github-actions bot added the area-ai-eval Microsoft.Extensions.AI.Evaluation and related label Aug 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds model provider information to the ChatTurnDetails class to provide better tracking of which provider is being used for AI model interactions. This enhances the evaluation reporting capabilities by including provider context alongside existing model information.

  • Adds ModelProvider property to ChatTurnDetails class with appropriate constructor overloads
  • Updates chat clients to populate the model provider information from ChatClientMetadata
  • Enhances the TypeScript UI to display model provider information in a separate column

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ChatTurnDetails.cs Adds ModelProvider property and new constructor overload with JSON serialization support
SimpleChatClient.cs Retrieves and passes ChatClientMetadata.ProviderName to ChatTurnDetails
ResponseCachingChatClient.cs Retrieves and passes ChatClientMetadata.ProviderName to ChatTurnDetails
ChatDetailsSection.tsx Adds separate column for model provider in the UI table
Microsoft.Extensions.AI.Evaluation.Reporting.json Updates API baseline with new property and constructor
ScenarioRunResultTests.cs Updates test data to include modelProvider parameter
ResponseCacheTester.cs Refactors inline variable usage and removes unused import
ChatTurnDetailsTests.cs Adds comprehensive test coverage for ModelProvider serialization scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@shyamnamboodiripad shyamnamboodiripad merged commit 06d1dca into dotnet:main Aug 15, 2025
6 checks passed
@shyamnamboodiripad shyamnamboodiripad deleted the provider branch August 15, 2025 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ai-eval Microsoft.Extensions.AI.Evaluation and related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants