Remove title and description keywords from root-level schemas in AIFunctionFactory.#6465
Merged
eiriktsarpalis merged 1 commit intodotnet:mainfrom May 20, 2025
Merged
Conversation
…AIFunctionFactory.
stephentoub
approved these changes
May 20, 2025
Member
|
I'm happy with the change, but what changed your opinion since #5826 (comment)... that it breaks some consumers? |
Member
Author
We had no reports of this creating issues with consumers until modelcontextprotocol/csharp-sdk#342. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an alternative solution to modelcontextprotocol/csharp-sdk#436, this PR removes the
titleanddescriptionkeywords from root-level schemas in AIFunctionFactory. This is due to the fact both keywords are already represented in the resultantAIFunctionvia theNameandDescriptionproperties respectively, and because keywords beyondtype,properties, andrequiredis known to create problems with certain clients in the context of MCP.Because both the
nameanddescriptionkeywords are optional in the schema, I do not consider this to be a breaking change.Fix modelcontextprotocol/csharp-sdk#342. Supersedes modelcontextprotocol/csharp-sdk#436