Enhance Function Invocation Extensibility for Microsoft.Extensions.AI #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

stephentoub merged 19 commits into dotnet:main from rogerbarreto:sk-issues/11678-function-invocation-specialization

Apr 30, 2025

Contributor

rogerbarreto commented Apr 23, 2025 •

edited

Loading

Proposal for MEAI Function Calling specialization

As my recent investigation in the Semantic Kernel prepareing it for doing function calling on top of MEAI abstractions, some changes would be required for seamless support.

Semantic Kernel's implementation changes made below as part for the investigation.

.Net: Update KernelFunctionInvokingChatClient as a specialization of MEAI.FunctionInvokingChatClient microsoft/semantic-kernel#11678

Microsoft Reviewers: Open in CodeFlow

rogerbarreto added 5 commits

April 23, 2025 10:34


          Allowing specialized function calling

4278d68


          ConversationId + integrating latest updates to MEAI client

d5af23a


          Fix documentation

6e1dba4


          Fix thread

8d05c62


          Fix thread

0eb7540

github-actions bot added the area-ai label

dotnet-policy-service bot assigned rogerbarreto

SteveSandersonMS reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

SteveSandersonMS reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

SteveSandersonMS reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

SteveSandersonMS reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

SteveSandersonMS reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

SteveSandersonMS reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

SteveSandersonMS reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

SteveSandersonMS reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

SteveSandersonMS reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

Member

SteveSandersonMS commented Apr 23, 2025

Thanks @rogerbarreto! This looks like a good direction to go in. While there are still some details to streamline, I'm hopeful we can figure it out pretty soon and make this change.

jeffhandley reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvocationContext.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

rogerbarreto added 4 commits

April 29, 2025 14:24


          Function Invocation changes

ca7127d


          Current UT passing, changes added

dd18a9a


          Adding UT for termination

6a163ae


          Termination update

25173c2

jeffhandley reviewed

View reviewed changes

NuGet.config Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

test/Libraries/Microsoft.Extensions.AI.Tests/ChatCompletion/FunctionInvokingChatClientTests.cs Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

rogerbarreto added 4 commits

April 30, 2025 17:39


          Address PR feedback

8366e95


          Merge branch 'sk-issues/11678-function-invocation-specialization' of h…

5e489be

…ttps://github.com/rogerbarreto/extensions into sk-issues/11678-function-invocation-specialization


          Public ShouldTerminate -> Terminate

63a6ab8


          Internalize FunctionInvocationResult ctor

6300c4d

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvocationContext.cs Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

Member

stephentoub left a comment

Looking much better! Almost there.


          Address PR comments

22d748a

rogerbarreto changed the title ~~Function Invocation specialization proposal for AI Extensions~~ Enhance Function Invocation Extensibility for Microsoft.Extensions.AI

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs Show resolved Hide resolved

rogerbarreto added 2 commits

April 30, 2025 19:00


          Simplify ctor

c4f4047


          Merge branch 'main' into sk-issues/11678-function-invocation-speciali…

05a2a12

…zation

stephentoub reviewed

View reviewed changes

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs Show resolved Hide resolved

stephentoub approved these changes

View reviewed changes

Member

stephentoub left a comment

Thanks!

stephentoub enabled auto-merge (squash)

April 30, 2025 18:35

stephentoub disabled auto-merge

April 30, 2025 18:35

stephentoub enabled auto-merge (squash)

April 30, 2025 18:35

stephentoub merged commit f8d25f4 into dotnet:main

6 checks passed

rogerbarreto mentioned this pull request

.Net: Update KernelFunctionInvokingChatClient as a specialization of MEAI.FunctionInvokingChatClient microsoft/semantic-kernel#11678

Merged

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ai