Avoid duplicate data in downloaded report file #6252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing default-exported modules, the JavaScript runtime creates an object with both the properties of the exported object and a 'default' property containing the same data. In the case of the download functionality in the report, this results in the evaluation data being duplicated in the downloaded file (once at the root level and then again inside the 'default' property under the root level). The fix in this commit avoids the problem by serializing the contents of the 'default' property if present and falling back to serializing the outer object otherwise.
github-actions
bot
added
the
area-ai-eval
peterwald
approved these changes
Apr 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing default-exported modules, the JavaScript runtime creates an object with both the properties of the exported object and a 'default' property containing the same data. In the case of the download functionality in the report, this results in the evaluation data being duplicated in the downloaded file (once at the root level and then again inside the 'default' property under the root level).
The fix in this commit avoids the problem by serializing the contents of the 'default' property if present and falling back to serializing the outer object otherwise.
Microsoft Reviewers: Open in CodeFlow