Couple of minor changes around doc comments

[shyamnamboodiripad]

Microsoft Reviewers: Open in CodeFlow

[shyamnamboodiripad]

@RussKie @stephentoub Looks like the dotnet-extensions-ai team is being included as required on all eval library PRs despite the following lines in the CODEOWNERS files (where dotnet-extensions-ai-evaluation appears ahead of dotnet-extensions-ai).

Any ideas on how we can fix the reviewer tagging to only include the dotnet-extensions-ai-evaluation team?

https://github.com/dotnet/extensions/blob/main/.github/CODEOWNERS#L20C1-L22C116

[RussKie]

@RussKie @stephentoub Looks like the dotnet-extensions-ai team is being included as required on all eval library PRs despite the following lines in the CODEOWNERS files (where dotnet-extensions-ai-evaluation appears ahead of dotnet-extensions-ai).

Any ideas on how we can fix the reviewer tagging to only include the dotnet-extensions-ai-evaluation team?

main/.github/CODEOWNERS#L20C1-L22C116

It's because of this:

extensions/.github/CODEOWNERS

Lines 24 to 27 in 2f973c9

	/src/Libraries/Microsoft.Extensions.AI @dotnet/dotnet-extensions-ai
	/src/Libraries/Microsoft.Extensions.AI.* @dotnet/dotnet-extensions-ai
	/test/Libraries/Microsoft.Extensions.AI @dotnet/dotnet-extensions-ai
	/test/Libraries/Microsoft.Extensions.AI.* @dotnet/dotnet-extensions-ai

It could be that the order is reversed. If reversing doesn't help, then you'll need to explicitly call out MEAI libraries.
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

[shyamnamboodiripad]

@RussKie @stephentoub Looks like the dotnet-extensions-ai team is being included as required on all eval library PRs despite the following lines in the CODEOWNERS files (where dotnet-extensions-ai-evaluation appears ahead of dotnet-extensions-ai).
Any ideas on how we can fix the reviewer tagging to only include the dotnet-extensions-ai-evaluation team?
main/.github/CODEOWNERS#L20C1-L22C116

It's because of this:

extensions/.github/CODEOWNERS

Lines 24 to 27 in 2f973c9

	/src/Libraries/Microsoft.Extensions.AI @dotnet/dotnet-extensions-ai
	/src/Libraries/Microsoft.Extensions.AI.* @dotnet/dotnet-extensions-ai
	/test/Libraries/Microsoft.Extensions.AI @dotnet/dotnet-extensions-ai
	/test/Libraries/Microsoft.Extensions.AI.* @dotnet/dotnet-extensions-ai

It could be that the order is reversed. If reversing doesn't help, then you'll need to explicitly call out MEAI libraries. https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

@RussKie Thanks - I have pushed a commit to this PR that reverses the order. Could you please approve if it looks good?

[shyamnamboodiripad]

FYI @peterwald Looks like CI flaked out with the following error (same as #5901)

VSTest(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Tests failed: /mnt/vss/_work/1/s/artifacts/TestResults/Release/Microsoft.Extensions.Caching.Hybrid.Tests_net8.0_x64.html [net8.0|x64]

Looks like only the Ubuntu leg failed - Windows is past the point of failure - so perhaps the failure is intermittent / non-deterministic.

[dotnet-comment-bot]

‼️ Found issues ‼️

Project	Coverage Type	Expected	Actual
Microsoft.Extensions.Caching.Hybrid	Line	86	82.77 🔻
Microsoft.Extensions.AI.Ollama	Line	80	78.2 🔻
Microsoft.Extensions.AI.Evaluation.Quality	Line	88	7.57 🔻
Microsoft.Extensions.AI.Evaluation.Quality	Branch	88	16.42 🔻
Microsoft.Extensions.AI.Evaluation.Console	Line	88	8.26 🔻
Microsoft.Extensions.AI.Evaluation.Console	Branch	88	17.07 🔻
Microsoft.Extensions.AI.Evaluation	Line	88	58.67 🔻
Microsoft.Extensions.AI.Evaluation	Branch	88	56.67 🔻
Microsoft.Gen.MetadataExtractor	Line	98	57.35 🔻
Microsoft.Gen.MetadataExtractor	Branch	98	62.5 🔻
Microsoft.Extensions.AI.OpenAI	Line	77	68.19 🔻
Microsoft.Extensions.AI.OpenAI	Branch	77	50.2 🔻
Microsoft.Extensions.AI.Evaluation.Reporting	Line	88	72.06 🔻
Microsoft.Extensions.AI.Evaluation.Reporting	Branch	88	64.8 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project	Expected	Actual
Microsoft.Extensions.AI	88	89
Microsoft.Extensions.AI.AzureAIInference	91	92

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=951837&view=codecoverage-tab

[dotnet-comment-bot]

‼️ Found issues ‼️

Project	Coverage Type	Expected	Actual
Microsoft.Extensions.AI.Evaluation.Quality	Line	88	7.57 🔻
Microsoft.Extensions.AI.Evaluation.Quality	Branch	88	16.42 🔻
Microsoft.Extensions.AI.Evaluation.Console	Line	88	8.26 🔻
Microsoft.Extensions.AI.Evaluation.Console	Branch	88	17.07 🔻
Microsoft.Extensions.Caching.Hybrid	Line	86	82.77 🔻
Microsoft.Extensions.AI.Evaluation	Line	88	58.67 🔻
Microsoft.Extensions.AI.Evaluation	Branch	88	56.67 🔻
Microsoft.Extensions.AI.Ollama	Line	80	78.2 🔻
Microsoft.Extensions.AI.OpenAI	Line	77	68.04 🔻
Microsoft.Extensions.AI.OpenAI	Branch	77	49.8 🔻
Microsoft.Extensions.AI.Evaluation.Reporting	Line	88	72.06 🔻
Microsoft.Extensions.AI.Evaluation.Reporting	Branch	88	64.8 🔻
Microsoft.Gen.MetadataExtractor	Line	98	57.35 🔻
Microsoft.Gen.MetadataExtractor	Branch	98	62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project	Expected	Actual
Microsoft.Extensions.AI.AzureAIInference	91	92
Microsoft.Extensions.AI	88	89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=951897&view=codecoverage-tab