Skip to content

Remove the ref int parameter from ChatConversationEvaluator.CanRenderAsync() #5896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

Remove the ref int parameter from ChatConversationEvaluator.CanRenderAsync() #5896

merged 1 commit into from
Feb 13, 2025

Conversation

peterwald
Copy link
Member

@peterwald peterwald commented Feb 13, 2025 •
edited by dotnet-policy-service bot
Loading

fixes #5895

Microsoft Reviewers: Open in CodeFlow

@peterwald peterwald requested a review from a team as a code owner February 13, 2025 17:43
@peterwald peterwald added the area-ai-eval Microsoft.Extensions.AI.Evaluation and related label Feb 13, 2025
@peterwald peterwald enabled auto-merge (squash) February 13, 2025 17:46
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 82.77 🔻
Microsoft.Extensions.AI.OpenAI Line 77 68.75 🔻
Microsoft.Extensions.AI.OpenAI Branch 77 50.41 🔻
Microsoft.Extensions.AI.Ollama Line 80 78.2 🔻
Microsoft.Extensions.AI.Evaluation.Quality Line 88 7.57 🔻
Microsoft.Extensions.AI.Evaluation.Quality Branch 88 16.42 🔻
Microsoft.Extensions.AI.Evaluation.Console Line 88 8.26 🔻
Microsoft.Extensions.AI.Evaluation.Console Branch 88 17.07 🔻
Microsoft.Extensions.AI.Evaluation Line 88 58.67 🔻
Microsoft.Extensions.AI.Evaluation Branch 88 56.67 🔻
Microsoft.Extensions.AI.Evaluation.Reporting Line 88 72.06 🔻
Microsoft.Extensions.AI.Evaluation.Reporting Branch 88 64.8 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.AzureAIInference 91 92
Microsoft.Extensions.AI.Abstractions 83 85
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=951536&view=codecoverage-tab

@peterwald peterwald merged commit 584a56a into dotnet:main Feb 13, 2025
6 checks passed
@peterwald peterwald deleted the async-ref branch February 13, 2025 18:26
@rnelson rnelson mentioned this pull request Mar 12, 2025
Open
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

@peterwald peterwald

Labels
area-ai-eval Microsoft.Extensions.AI.Evaluation and related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CanRenderAsync should not have a ref parameter
3 participants
@peterwald @dotnet-comment-bot @stephentoub