Skip to content

Fix up a few more stale references to Complete{Streaming}Async (mainly tests) #5876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

Fix up a few more stale references to Complete{Streaming}Async (mainly tests) #5876

merged 1 commit into from
Feb 11, 2025

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Feb 11, 2025 •
edited by dotnet-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@stephentoub stephentoub requested a review from a team as a code owner February 11, 2025 15:50
@stephentoub stephentoub enabled auto-merge (squash) February 11, 2025 15:53
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Ollama Line 80 78.2 🔻
Microsoft.Extensions.Caching.Hybrid Line 86 82.69 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻
Microsoft.Extensions.AI.OpenAI Line 77 68.75 🔻
Microsoft.Extensions.AI.OpenAI Branch 77 50.41 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.Abstractions 83 85
Microsoft.Extensions.AI.AzureAIInference 91 92
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=948383&view=codecoverage-tab

@stephentoub stephentoub merged commit 131d30b into dotnet:main Feb 11, 2025
6 checks passed
@jeffhandley jeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
@rnelson rnelson mentioned this pull request Mar 12, 2025
Open
@renovate renovate bot mentioned this pull request Mar 19, 2025
Merged
1 task
@stephentoub stephentoub deleted the renamingfollowups branch March 21, 2025 14:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@stephentoub stephentoub

Labels
area-ai Microsoft.Extensions.AI libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephentoub @dotnet-comment-bot @eiriktsarpalis @jeffhandley