Skip to content

Generalise how package version isn't stabilized for dev/preview stages #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

Generalise how package version isn't stabilized for dev/preview stages #5864

merged 1 commit into from
Feb 12, 2025

Conversation

RussKie
Copy link
Contributor

@RussKie RussKie commented Feb 10, 2025 •
edited by dotnet-policy-service bot
Loading

Follow up on #5632

Microsoft Reviewers: Open in CodeFlow

@RussKie RussKie requested review from a team as code owners February 10, 2025 00:25
@RussKie
Copy link
Contributor Author

RussKie commented Feb 10, 2025

Replace #5640.

/cc: @joperezr

@RussKie RussKie mentioned this pull request Feb 10, 2025
Closed
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻
Microsoft.Extensions.Caching.Hybrid Line 86 82.92 🔻
Microsoft.Extensions.AI.Ollama Line 80 78.11 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.AzureAIInference 91 92
Microsoft.Extensions.AI.Abstractions 83 85

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=946062&view=codecoverage-tab

wtgodbe
wtgodbe approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻
Microsoft.Extensions.Caching.Hybrid Line 86 82.92 🔻
Microsoft.Extensions.AI.Ollama Line 80 78.2 🔻
Microsoft.Extensions.AI.OpenAI Line 77 68.75 🔻
Microsoft.Extensions.AI.OpenAI Branch 77 50.41 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.AzureAIInference 91 92
Microsoft.Extensions.AI.Abstractions 83 85
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=949220&view=codecoverage-tab

@RussKie RussKie merged commit 4efecdf into dotnet:main Feb 12, 2025
6 checks passed
@RussKie RussKie deleted the staging2 branch February 12, 2025 04:49
@RussKie RussKie mentioned this pull request Feb 12, 2025
Merged
@RussKie RussKie mentioned this pull request Mar 11, 2025
Merged
@rnelson rnelson mentioned this pull request Mar 12, 2025
Open
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sebastienros sebastienros sebastienros approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees

@RussKie RussKie

Labels
area-infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RussKie @dotnet-comment-bot @sebastienros @wtgodbe