Skip to content

Make a number of improvements to the OpenAI serialization helpers. #5799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 17, 2025
Merged

Make a number of improvements to the OpenAI serialization helpers. #5799

merged 3 commits into from
Jan 17, 2025

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Jan 16, 2025 •
edited by dotnet-policy-service bot
Loading

  1. Makes a number of fixes in the OpenAI mapping logic.
  2. Adds a custom converter for the OpenAIChatCompletionRequest envelope type that uses OpenAI wire format. This should make it possible to bind to that type directly in the context of MVC apps.
Microsoft Reviewers: Open in CodeFlow

@eiriktsarpalis eiriktsarpalis requested a review from a team as a code owner January 16, 2025 19:47
@eiriktsarpalis eiriktsarpalis enabled auto-merge (squash) January 16, 2025 20:09
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.OpenAI 77 78

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=920173&view=codecoverage-tab

@evgenyfedorov2 evgenyfedorov2 added the area-ai Microsoft.Extensions.AI libraries label Jan 17, 2025
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.OpenAI 77 78

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=921110&view=codecoverage-tab

@eiriktsarpalis eiriktsarpalis merged commit c63bc2c into dotnet:main Jan 17, 2025
6 checks passed
@eiriktsarpalis eiriktsarpalis deleted the improve-openai-serialization branch January 17, 2025 17:38
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-ai Microsoft.Extensions.AI libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eiriktsarpalis @dotnet-comment-bot @stephentoub @evgenyfedorov2