Ensure Ollama streaming updates specify a CompletionId.#5795
Merged
eiriktsarpalis merged 2 commits intodotnet:mainfrom Jan 14, 2025
Merged
Ensure Ollama streaming updates specify a CompletionId.#5795eiriktsarpalis merged 2 commits intodotnet:mainfrom
eiriktsarpalis merged 2 commits intodotnet:mainfrom
Conversation
Collaborator
|
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=916794&view=codecoverage-tab |
stephentoub
reviewed
Jan 14, 2025
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=917062&view=codecoverage-tab |
stephentoub
reviewed
Jan 14, 2025
src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIModelMapper.ChatCompletion.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while working on eiriktsarpalis/blackbeard-extension-cs#1. Non-streaming completions use the
CreatedAttimestamp as the completion id, however this is being omitted for the case of streaming completions.Microsoft Reviewers: Open in CodeFlow