Skip to content

Conversation

@jodydonetti
Copy link
Contributor

@jodydonetti jodydonetti commented Dec 20, 2024

Microsoft Reviewers: Open in CodeFlow

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Caching.Hybrid 75 83
Microsoft.Extensions.AI.Ollama 0 80
Microsoft.Extensions.AI.OpenAI 0 75
Microsoft.Extensions.AI.AzureAIInference 0 80
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.AI 0 77
Microsoft.Extensions.AI.Abstractions 0 77

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=901119&view=codecoverage-tab

@jodydonetti
Copy link
Contributor Author

Add missing reference.

@mgravell
Copy link
Contributor

mgravell commented Dec 21, 2024

Code change is fine, but we should target main ? Actually, I need to check there whether we should be targeting main or dev - I still haven't fully sunk into the release cycle "here" (dotnet/extensions).

@jodydonetti
Copy link
Contributor Author

Code change is fine, but we should target main ? Actually, I need to check there whether we should be targeting main or dev - I still haven't fully sunk into the release cycle "here" (dotnet/extensions).

I picked what seemed like the latest preview version, but can did it again easily since it's literally just 2 chars 😅

Let me know if I do that or you prefer to rebase etc.

@mgravell
Copy link
Contributor

Almost certainly main - you may be able to simply edit the PR to retarget as long as that doesn't try to bring over all the intermediate commits - or it may be easier to redo the change! I need to check with @joperezr on what the process is meant to be for the other branches.

@jodydonetti
Copy link
Contributor Author

Done, here's the new one.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants