Skip to content

Rework UseChatOptions as ConfigureOptions #5606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2024
Merged

Rework UseChatOptions as ConfigureOptions #5606

merged 3 commits into from
Nov 7, 2024

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Nov 6, 2024 •
edited
Loading

  • Renames UseChatOptions / UseEmbeddingGenerationOptions to be ConfigureOptions
  • Changes the delegate to just be Action<XxOptions> rather than Func<XxOptions?, XxOptions?>
  • The delegate is now always invoked with a clone of the original options (or a new instance if none was provided) so that the callback can simply mutate / configure the options instance.
Microsoft Reviewers: Open in CodeFlow

@stephentoub stephentoub requested a review from a team as a code owner November 6, 2024 23:06
eiriktsarpalis
eiriktsarpalis reviewed Nov 7, 2024
View reviewed changes
@stephentoub
Rework UseChat/EmbeddingGenerationOptions to always clone
0421fc6 
The callbacks now configure the supplied instance.
@stephentoub stephentoub changed the title Update README to include a section on UseChatOptions Rework UseChatOptions as ConfigureOptions Nov 7, 2024
@stephentoub
Copy link
Member Author

@glennc, FYI

eiriktsarpalis
eiriktsarpalis approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephentoub stephentoub merged commit 8b320e2 into dotnet:main Nov 7, 2024
6 checks passed
@stephentoub stephentoub deleted the readmechatoptions branch November 7, 2024 19:08
stephentoub added a commit to stephentoub/extensions that referenced this pull request Nov 19, 2024
@stephentoub
Rework UseChatOptions as ConfigureOptions (dotnet#5606)
4f775a0 
* Update README to include a section on UseChatOptions

* Rework UseChat/EmbeddingGenerationOptions to always clone

The callbacks now configure the supplied instance.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
@jeffhandley jeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

@luisquintanilla luisquintanilla Awaiting requested review from luisquintanilla

Assignees

@stephentoub stephentoub

Labels
area-ai Microsoft.Extensions.AI libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephentoub @SteveSandersonMS @eiriktsarpalis @jeffhandley