Lower AIJsonUtilities to STJv8 and move to Abstractions library.
#5582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriktsarpalis
commented
Oct 28, 2024
src/Libraries/Microsoft.Extensions.AI.Abstractions/Utilities/AIJsonUtilities.Schema.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Oct 28, 2024
stephentoub
reviewed
Oct 30, 2024
stephentoub
reviewed
Oct 30, 2024
stephentoub
reviewed
Oct 30, 2024
stephentoub
reviewed
Oct 30, 2024
stephentoub
approved these changes
Oct 30, 2024
eiriktsarpalis
force-pushed
the
lower-meai
branch
from
20067e0 to
e0b5fc7
Compare
stephentoub
approved these changes
Oct 31, 2024
This was referenced Oct 31, 2024
joperezr
pushed a commit
to joperezr/extensions
that referenced
this pull request
Nov 5, 2024
…otnet#5582) * Lower AIJsonUtilities to STJv8 and move to Abstractions library. * Add README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively moves most of https://github.com/eiriktsarpalis/stj-schema-mapper (including its test suites) and makes it available as a polyfill to .NET 9's
JsonSchemaExporterin dotnet/extensions. This makes it possible to lower the dependency of AIJsonUtilities to STJ version 8 and move it to the Abstractions library.Microsoft Reviewers: Open in CodeFlow