Remove project names #4532
Merged
Remove project names #4532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
joperezr
reviewed
Oct 6, 2023
| @@ -11,7 +11,7 @@ public static class TelemetryConstants | |||
| /// <summary> | |||
| /// Request metadata key that is used when storing request metadata object. | |||
| /// </summary> | |||
| public const string RequestMetadataKey = "R9-RequestMetadata"; | |||
| public const string RequestMetadataKey = "Extensions-RequestMetadata"; | |||
There was a problem hiding this comment.
I'm assuming we do want to make this change, yet we do expect this to cause breaks for teams currently depending on this. @geeknoid can you confirm?
There was a problem hiding this comment.
This should be fine, it's something teams will have to deal with when upgrading.
|
I am assuming that some of these suggestions are not good, but I can then add comments to clarify the reasons for later. |
joperezr
reviewed
Oct 6, 2023
src/Libraries/Microsoft.Extensions.Diagnostics.HealthChecks.Common/Metric.cs
Outdated
Show resolved
Hide resolved
|
Changes look good to me, but it would be good to also get a review from @xakep139 on this especially due to some of the telemetry changes being done here. |
xakep139
approved these changes
Oct 7, 2023
RussKie
approved these changes
Oct 9, 2023
geeknoid
approved these changes
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Microsoft Reviewers: Open in CodeFlow