Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke DependencyInjection.NamedServices #4225

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Nuke DependencyInjection.NamedServices #4225

merged 1 commit into from
Aug 5, 2023

Conversation

geeknoid
Copy link
Member

@geeknoid geeknoid commented Jul 28, 2023

null

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned geeknoid Jul 28, 2023
@geeknoid geeknoid force-pushed the geeknoid/namedsvc branch 2 times, most recently from acc15ff to 08fd051 Compare July 29, 2023 10:56
@geeknoid
Copy link
Member Author

Tests will fail in this PR until dotnet/runtime#89447 is fixed.

@xakep139
Copy link
Contributor

Tests will fail in this PR until dotnet/runtime#89447 is fixed.

It is fixed

@geeknoid
Copy link
Member Author

Tests will fail in this PR until dotnet/runtime#89447 is fixed.

It is fixed

Yeah, I noticed. We need to wait for Arcade to update this repo to point to the latest bits from dotnet/extensions. This should happen in the next few days.

@RussKie
Copy link
Member

RussKie commented Jul 30, 2023

We're blocked by dotnet/aspnetcore#49704.

@geeknoid geeknoid force-pushed the geeknoid/namedsvc branch 2 times, most recently from 25a0b83 to 45b4ee6 Compare August 2, 2023 16:39
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM barring a green build once we fix the ingestion flow.

@RussKie
Copy link
Member

RussKie commented Aug 3, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@geeknoid geeknoid merged commit 2d642df into main Aug 5, 2023
6 checks passed
@geeknoid geeknoid deleted the geeknoid/namedsvc branch August 5, 2023 05:43
@ghost ghost added this to the 8.0 RC1 milestone Aug 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants