Update branding to 3.0.1 #2392
Merged
Update branding to 3.0.1 #2392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
commented
Sep 24, 2019
dougbu
commented
- aspnet/AspNetCore-Internal#3153
dougbu
force-pushed
the
dougbu/branding.3.0.1
branch
from
02fb36f to
353a780
Compare
dougbu
commented
Sep 26, 2019
| @@ -20,7 +39,8 @@ | |||
| --> | |||
| <UseLatestPackageReferences Condition=" '$(UseLatestPackageReferences)' == '' AND '$(IsServicingBuild)' != 'true' ">true</UseLatestPackageReferences> | |||
| <UseLatestPackageReferences Condition=" '$(UseLatestPackageReferences)' == '' AND '$(IsImplementationProject)' != 'true' ">true</UseLatestPackageReferences> | |||
| <UseLatestPackageReferences Condition=" '$(UseLatestPackageReferences)' == '' AND '$(IsImplementationProject)' == 'true' AND ( '$(IsServicingBuild)' != 'true' OR '$(IsPackable)' == 'true' ) ">true</UseLatestPackageReferences> | |||
| <UseLatestPackageReferences | |||
| Condition=" '$(UseLatestPackageReferences)' == '' AND '$(IsImplementationProject)' == 'true' AND '$(IsPackable)' == 'true' ">true</UseLatestPackageReferences> | |||
There was a problem hiding this comment.
Similar to dotnet/aspnetcore#14404, the changes in this file are all about nits. The change here is again about the redundancy of checking '$(IsServicingBuild)' != 'true' twice.
|
Not good. Even a seemingly-successful leg of the build (Ubuntu 16.04 Debug) hit package resolution conflicts referring to projects elsewhere in the repo. Not sure where the 3.0.0 versions is coming from. Checking whether this reproduces locally… |
- aspnet/AspNetCore-Internal#3153
- add `$(IgnorePackageBaselines)` property nits: - add general comment in ResolveReferences.targets - remove `$(RestoreSources)` settings
- no changes in known frameworks, targeting pack features, et cetera nits: - remove downlevel patches from PatchConfig.props - remove extra checks and whitespace from `Condition`s in ResolveReferences.targets - copy general comment from AspNetCore's ResolveReferences.targets
dougbu
force-pushed
the
dougbu/branding.3.0.1
branch
from
6f5f9c3 to
a2777af
Compare
- do not pack Microsoft.Internal.Extensions.Refs when servicing (either) - use `$(IsPackable)` property to clarify conditions
|
/bump reviewers |
wtgodbe
approved these changes
Sep 27, 2019
ghost
deleted the
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.