Skip to content

Commit e7224fb

Browse files
committed
Merged PR 48958: Mark release builds as "stable"
#### AI description (iteration 1) #### PR Classification New feature #### PR Summary This pull request marks release builds as "stable" by setting the `DotNetFinalVersionKind` property to "release". - `eng/Versions.props`: Added `DotNetFinalVersionKind` property to mark builds as stable for release branches. - `eng/MSBuild/ProjectStaging.props`: Removed redundant setting of `DotNetFinalVersionKind` property. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
1 parent 625ed7b commit e7224fb

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

eng/MSBuild/ProjectStaging.props

-6
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,6 @@
1111
-->
1212
<_IsStable Condition="('$(Stage)' != 'dev' and '$(Stage)' != 'preview') Or '$(MSBuildProjectName)' == 'Microsoft.AspNetCore.Testing'">true</_IsStable>
1313

14-
<!--
15-
When DotNetFinalVersionKind is set to 'release' (only for the release branches),
16-
the build will produce stable outputs for 'Shipping' packages.
17-
-->
18-
<DotNetFinalVersionKind Condition=" '$(StabilizePackageVersion)' == 'true' And '$(DotNetFinalVersionKind)' == '' And '$(_IsStable)' == 'true' ">release</DotNetFinalVersionKind>
19-
2014
<!-- Preview packages: do not use stable branding and do not warn about lack of [Experimental] -->
2115
<NoWarn Condition="'$(Stage)' == 'dev' or '$(Stage)' == 'preview'">$(NoWarn);LA0003</NoWarn>
2216
<!--

eng/Versions.props

+9
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,15 @@
1212
When StabilizePackageVersion is set to 'true', this branch will produce stable outputs for 'Shipping' packages
1313
-->
1414
<StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">true</StabilizePackageVersion>
15+
16+
<!--
17+
When DotNetFinalVersionKind is set to 'release' (only for the release branches),
18+
the build will produce stable outputs for 'Shipping' packages.
19+
20+
This is used by the Arcade SDK (Publish.proj) to determine if the build is a release build or not.
21+
-->
22+
<DotNetFinalVersionKind>release</DotNetFinalVersionKind>
23+
1524
<!-- Enabling this rule will cause build failures on undocumented public APIs. -->
1625
<SkipArcadeNoWarnCS1591>true</SkipArcadeNoWarnCS1591>
1726
</PropertyGroup>

0 commit comments

Comments
 (0)