Remove check make tests beter

Author: pakrym

shared/Microsoft.Extensions.Buffers.MemoryPool.Sources/MemoryPoolBlock.Release.cs

@@ -53,7 +53,6 @@ internal MemoryPoolBlock(SlabMemoryPool pool, MemoryPoolSlab slab, int offset, i
 
         public void Dispose()
         {
-            if (!Slab.IsActive) MemoryPoolThrowHelper.ThrowObjectDisposedException(MemoryPoolThrowHelper.ExceptionArgument.MemoryPoolBlock);
             Pool.Return(this);
         }
 

test/Microsoft.Extensions.Internal.Test/MemoryPoolTests.Debug.cs

@@ -26,10 +26,9 @@ public void DisposeWithActiveBlocksThrows()
         {
             var memoryPool = new SlabMemoryPool();
             var block = memoryPool.Rent();
-            var exception = Assert.Throws<InvalidOperationException>(() => memoryPool.Dispose());
-            Assert.Equal("Memory pool with active blocks is being disposed, 30 of 31 returned", exception.Message);
+            ExpectDisposeException(memoryPool);
 
-            exception = Assert.Throws<InvalidOperationException>(() => block.Dispose());
+            var exception = Assert.Throws<InvalidOperationException>(() => block.Dispose());
             Assert.Equal("Block is being returned to disposed pool", exception.Message);
         }
 
@@ -39,10 +38,9 @@ public void GetMemoryOfDisposedThrows()
             var memoryPool = new SlabMemoryPool();
             var block = memoryPool.Rent();
 
-            var exception = Assert.Throws<InvalidOperationException>(() => memoryPool.Dispose());
-            Assert.Equal("Memory pool with active blocks is being disposed, 30 of 31 returned", exception.Message);
+            ExpectDisposeException(memoryPool);
 
-            exception = Assert.Throws<ObjectDisposedException>(() => block.Memory);
+            var exception = Assert.Throws<ObjectDisposedException>(() => block.Memory);
             Assert.Equal("Cannot access a disposed object.\r\nObject name: 'MemoryPoolBlock'.", exception.Message);
         }
 
@@ -52,10 +50,10 @@ public void GetMemoryPinOfDisposedThrows()
             var memoryPool = new SlabMemoryPool();
             var block = memoryPool.Rent();
             var memory = block.Memory;
-            var exception = Assert.Throws<InvalidOperationException>(() => memoryPool.Dispose());
-            Assert.Equal("Memory pool with active blocks is being disposed, 30 of 31 returned", exception.Message);
 
-            exception = Assert.Throws<ObjectDisposedException>(() => memory.Pin());
+            ExpectDisposeException(memoryPool);
+
+            var exception = Assert.Throws<ObjectDisposedException>(() => memory.Pin());
             Assert.Equal("Cannot access a disposed object.\r\nObject name: 'MemoryPoolBlock'.", exception.Message);
         }
 
@@ -65,8 +63,8 @@ public void GetMemorySpanOfDisposedThrows()
             var memoryPool = new SlabMemoryPool();
             var block = memoryPool.Rent();
             var memory = block.Memory;
-            var exception = Assert.Throws<InvalidOperationException>(() => memoryPool.Dispose());
-            Assert.Equal("Memory pool with active blocks is being disposed, 30 of 31 returned", exception.Message);
+
+            ExpectDisposeException(memoryPool);
 
             var threw = false;
             try
@@ -87,12 +85,18 @@ public void GetMemoryTryGetArrayOfDisposedThrows()
             var memoryPool = new SlabMemoryPool();
             var block = memoryPool.Rent();
             var memory = block.Memory;
-            var exception = Assert.Throws<InvalidOperationException>(() => memoryPool.Dispose());
-            Assert.Equal("Memory pool with active blocks is being disposed, 30 of 31 returned", exception.Message);
 
-            exception = Assert.Throws<ObjectDisposedException>(() => MemoryMarshal.TryGetArray<byte>(memory, out _));
+            ExpectDisposeException(memoryPool);
+
+            var exception = Assert.Throws<ObjectDisposedException>(() => MemoryMarshal.TryGetArray<byte>(memory, out _));
             Assert.Equal("Cannot access a disposed object.\r\nObject name: 'MemoryPoolBlock'.", exception.Message);
         }
+
+        private static void ExpectDisposeException(SlabMemoryPool memoryPool)
+        {
+            var exception = Assert.Throws<InvalidOperationException>(() => memoryPool.Dispose());
+            Assert.Equal("Memory pool with active blocks is being disposed, 30 of 31 returned", exception.Message);
+        }
     }
 }