Add missing [JsonIgnore] on ChatCompletion.Message (#5552)

stephentoub · web-flow · commit 8fbeca093277 · 2024-10-22T05:58:03.000-04:00
This property is an accelerator into Choices. It's already serialized as part of Choices and shouldn't be duplicated.
diff --git a/src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatCompletion.cs b/src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatCompletion.cs
@@ -42,6 +42,7 @@ public IList<ChatMessage> Choices
     /// If there are multiple choices, this property returns the first choice.
     /// If <see cref="Choices"/> is empty, this will throw. Use <see cref="Choices"/> to access all choices directly."/>.
     /// </remarks>
+    [JsonIgnore]
     public ChatMessage Message
     {
         get

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,7 @@ public IList<ChatMessage> Choices`
`42`	`42`	`/// If there are multiple choices, this property returns the first choice.`
`43`	`43`	`/// If <see cref="Choices"/> is empty, this will throw. Use <see cref="Choices"/> to access all choices directly."/>.`
`44`	`44`	`/// </remarks>`
	`45`	`+ [JsonIgnore]`
`45`	`46`	`public ChatMessage Message`
`46`	`47`	`{`
`47`	`48`	`get`