address code review feedback

Author: adamsitnik

src/Libraries/Microsoft.Extensions.DataIngestion.Abstractions/IngestionChunk.cs

@@ -4,7 +4,6 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
-using System.Diagnostics.CodeAnalysis;
 using Microsoft.Shared.Diagnostics;
 
 namespace Microsoft.Extensions.DataIngestion;
@@ -13,37 +12,11 @@ namespace Microsoft.Extensions.DataIngestion;
 /// Represents a chunk of content extracted from an <see cref="IngestionDocument"/>.
 /// </summary>
 /// <typeparam name="T">The type of the content.</typeparam>
-[DebuggerDisplay("{Content}")]
-[Experimental("MEDI001")]
+[DebuggerDisplay("Content = {Content}")]
 public sealed class IngestionChunk<T>
 {
     private Dictionary<string, object>? _metadata;
 
-    /// <summary>
-    /// Gets the content of the chunk.
-    /// </summary>
-    public T Content { get; }
-
-    /// <summary>
-    /// Gets the document from which this chunk was extracted.
-    /// </summary>
-    public IngestionDocument Document { get; }
-
-    /// <summary>
-    /// Gets additional context for the chunk.
-    /// </summary>
-    public string? Context { get; }
-
-    /// <summary>
-    /// Gets a value indicating whether this chunk has metadata.
-    /// </summary>
-    public bool HasMetadata => _metadata?.Count > 0;
-
-    /// <summary>
-    /// Gets the metadata associated with this chunk.
-    /// </summary>
-    public IDictionary<string, object> Metadata => _metadata ??= [];
-
     /// <summary>
     /// Initializes a new instance of the <see cref="IngestionChunk{T}"/> class.
     /// </summary>
@@ -70,4 +43,29 @@ public IngestionChunk(T content, IngestionDocument document, string? context = n
         Document = Throw.IfNull(document);
         Context = context;
     }
+
+    /// <summary>
+    /// Gets the content of the chunk.
+    /// </summary>
+    public T Content { get; }
+
+    /// <summary>
+    /// Gets the document from which this chunk was extracted.
+    /// </summary>
+    public IngestionDocument Document { get; }
+
+    /// <summary>
+    /// Gets additional context for the chunk.
+    /// </summary>
+    public string? Context { get; }
+
+    /// <summary>
+    /// Gets a value indicating whether this chunk has metadata.
+    /// </summary>
+    public bool HasMetadata => _metadata?.Count > 0;
+
+    /// <summary>
+    /// Gets the metadata associated with this chunk.
+    /// </summary>
+    public IDictionary<string, object> Metadata => _metadata ??= [];
 }

src/Libraries/Microsoft.Extensions.DataIngestion.Abstractions/IngestionChunkProcessor.cs

@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using System.Threading;
 
 namespace Microsoft.Extensions.DataIngestion;
@@ -11,7 +10,6 @@ namespace Microsoft.Extensions.DataIngestion;
 /// Processes chunks in a pipeline.
 /// </summary>
 /// <typeparam name="T">The type of the chunk content.</typeparam>
-[Experimental("MEDI001")]
 public abstract class IngestionChunkProcessor<T>
 {
     /// <summary>

src/Libraries/Microsoft.Extensions.DataIngestion.Abstractions/IngestionChunkWriter.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using System.Threading;
 using System.Threading.Tasks;
 
@@ -13,7 +12,6 @@ namespace Microsoft.Extensions.DataIngestion;
 /// Writes chunks to a destination.
 /// </summary>
 /// <typeparam name="T">The type of the chunk content.</typeparam>
-[Experimental("MEDI001")]
 public abstract class IngestionChunkWriter<T> : IDisposable
 {
     /// <summary>

src/Libraries/Microsoft.Extensions.DataIngestion.Abstractions/IngestionChunker.cs

@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using System.Threading;
 
 namespace Microsoft.Extensions.DataIngestion;
@@ -11,7 +10,6 @@ namespace Microsoft.Extensions.DataIngestion;
 /// Splits an <see cref="IngestionDocument"/> into chunks.
 /// </summary>
 /// <typeparam name="T">The type of the chunk content.</typeparam>
-[Experimental("MEDI001")]
 public abstract class IngestionChunker<T>
 {
     /// <summary>

src/Libraries/Microsoft.Extensions.DataIngestion.Abstractions/IngestionDocument.cs

@@ -3,15 +3,13 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using Microsoft.Shared.Diagnostics;
 
 namespace Microsoft.Extensions.DataIngestion;
 
 /// <summary>
 /// A format-agnostic container that normalizes diverse input formats into a structured hierarchy.
 /// </summary>
-[Experimental("MEDI001")]
 public sealed class IngestionDocument
 {
     /// <summary>

src/Libraries/Microsoft.Extensions.DataIngestion.Abstractions/IngestionDocumentElement.cs

@@ -4,7 +4,6 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
-using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using Microsoft.Shared.Diagnostics;
 
@@ -15,11 +14,12 @@ namespace Microsoft.Extensions.DataIngestion;
 /// <summary>
 /// Represents an element within an <see cref="IngestionDocument"/>.
 /// </summary>
-[DebuggerDisplay("{GetType().Name}: {GetMarkdown()}")]
-[Experimental("MEDI001")]
+[DebuggerDisplay("Type = {GetType().Name}, Markdown = {GetMarkdown()}")]
 public abstract class IngestionDocumentElement
 {
-    private protected string Markdown;
+#pragma warning disable IDE1006 // Naming Styles
+    private protected string _markdown;
+#pragma warning restore IDE1006 // Naming Styles
 
     /// <summary>
     /// Initializes a new instance of the <see cref="IngestionDocumentElement"/> class.
@@ -28,12 +28,12 @@ public abstract class IngestionDocumentElement
     /// <exception cref="ArgumentNullException"><paramref name="markdown"/> is <see langword="null"/> or empty.</exception>
     private protected IngestionDocumentElement(string markdown)
     {
-        Markdown = string.IsNullOrEmpty(markdown) ? throw new ArgumentNullException(nameof(markdown)) : markdown;
+        _markdown = string.IsNullOrEmpty(markdown) ? throw new ArgumentNullException(nameof(markdown)) : markdown;
     }
 
     private protected IngestionDocumentElement()
     {
-        Markdown = null!;
+        _markdown = null!;
     }
 
     private Dictionary<string, object?>? _metadata;
@@ -47,7 +47,7 @@ private protected IngestionDocumentElement()
     /// Gets the markdown representation of the element.
     /// </summary>
     /// <returns>The markdown representation.</returns>
-    public virtual string GetMarkdown() => Markdown;
+    public virtual string GetMarkdown() => _markdown;
 
     /// <summary>
     /// Gets or sets the page number where this element appears.
@@ -68,7 +68,6 @@ private protected IngestionDocumentElement()
 /// <summary>
 /// A section can be just a page or a logical grouping of elements in a document.
 /// </summary>
-[Experimental("MEDI001")]
 public sealed class IngestionDocumentSection : IngestionDocumentElement
 {
     /// <summary>
@@ -100,7 +99,6 @@ public override string GetMarkdown()
 /// <summary>
 /// Represents a paragraph in a document.
 /// </summary>
-[Experimental("MEDI001")]
 public sealed class IngestionDocumentParagraph : IngestionDocumentElement
 {
     /// <summary>
@@ -116,7 +114,6 @@ public IngestionDocumentParagraph(string markdown)
 /// <summary>
 /// Represents a header in a document.
 /// </summary>
-[Experimental("MEDI001")]
 public sealed class IngestionDocumentHeader : IngestionDocumentElement
 {
     /// <summary>
@@ -137,7 +134,6 @@ public IngestionDocumentHeader(string markdown)
 /// <summary>
 /// Represents a footer in a document.
 /// </summary>
-[Experimental("MEDI001")]
 public sealed class IngestionDocumentFooter : IngestionDocumentElement
 {
     /// <summary>
@@ -153,7 +149,6 @@ public IngestionDocumentFooter(string markdown)
 /// <summary>
 /// Represents a table in a document.
 /// </summary>
-[Experimental("MEDI001")]
 public sealed class IngestionDocumentTable : IngestionDocumentElement
 {
     /// <summary>
@@ -188,7 +183,6 @@ public IngestionDocumentTable(string markdown, IngestionDocumentElement?[,] cell
 /// <summary>
 /// Represents an image in a document.
 /// </summary>
-[Experimental("MEDI001")]
 public sealed class IngestionDocumentImage : IngestionDocumentElement
 {
     /// <summary>

src/Libraries/Microsoft.Extensions.DataIngestion.Abstractions/IngestionDocumentProcessor.cs

@@ -1,7 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-using System.Diagnostics.CodeAnalysis;
 using System.Threading;
 using System.Threading.Tasks;
 
@@ -10,7 +9,6 @@ namespace Microsoft.Extensions.DataIngestion;
 /// <summary>
 /// Part of the document processing pipeline that takes a <see cref="IngestionDocument"/> as input and produces a (potentially modified) <see cref="IngestionDocument"/> as output.
 /// </summary>
-[Experimental("MEDI001")]
 public abstract class IngestionDocumentProcessor
 {
     /// <summary>