Fix warning breaking official build, enable warningAsError in all pipelines (#6988)

* Workaround assembly downgrade in SemanticKernel packages

* Enable warning as error in pipelines

And make source-index step use similar build entrypoint.

* Consistently apply warnAsError in BuildAndTest.yml

* Keep warnAsError disabled for PR validation

This allows folks to get test results without being blocked by warnings.

Make sure the job testing for warnings runs on windows to ensure it builds a superset of targets.

Author: ericstj

azure-pipelines-public.yml

@@ -237,10 +237,10 @@ stages:
 
         pool:
           name: $(DncEngPublicBuildPool)
-          demands: ImageOverride -equals build.ubuntu.2004.amd64.open
+          demands: ImageOverride -equals windows.vs2022preview.amd64.open
 
         variables:
-          - _buildScript: $(Build.SourcesDirectory)/build.sh --ci
+          - _buildScript: $(Build.SourcesDirectory)/build.cmd -ci -NativeToolsOnMachine
 
         preSteps:
           - checkout: self
@@ -257,4 +257,4 @@ stages:
               repoTestResultsPath: $(Build.Arcade.TestResultsPath)
               skipTests: true
               skipQualityGates: true
-              isWindows: false
+              isWindows: true

azure-pipelines-unofficial.yml

@@ -132,7 +132,6 @@ extends:
                 repoTestResultsPath: $(Build.Arcade.TestResultsPath)
                 skipQualityGates: ${{ eq(variables['SkipQualityGates'], 'true') }}
                 isWindows: true
-                warnAsError: 0
 
           # ----------------------------------------------------------------
           # This job build and run tests on Ubuntu
@@ -163,7 +162,6 @@ extends:
                 repoTestResultsPath: $(Build.Arcade.TestResultsPath)
                 skipQualityGates: ${{ eq(variables['SkipQualityGates'], 'true') }}
                 isWindows: false
-                warnAsError: 0
 
     # ----------------------------------------------------------------
     # This stage performs quality gates enforcements

azure-pipelines.yml

@@ -117,6 +117,8 @@ variables:
   - ${{ if and(ne(variables['runAsPublic'], 'true'), notin(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.SourceBranch'], 'refs/heads/main')) }}:
     - name: enableSourceIndex
       value: true
+    - name: sourceIndexBuildCommand
+      value: $(Build.SourcesDirectory)/build.cmd -ci -NativeToolsOnMachine
   - ${{ else }}:
     - name: enableSourceIndex
       value: false
@@ -206,7 +208,6 @@ extends:
                 repoTestResultsPath: $(Build.Arcade.TestResultsPath)
                 skipQualityGates: ${{ eq(variables['SkipQualityGates'], 'true') }}
                 isWindows: true
-                warnAsError: 0
 
           # ----------------------------------------------------------------
           # This job build and run tests on Ubuntu
@@ -237,7 +238,6 @@ extends:
                 repoTestResultsPath: $(Build.Arcade.TestResultsPath)
                 skipQualityGates: ${{ eq(variables['SkipQualityGates'], 'true') }}
                 isWindows: false
-                warnAsError: 0
 
     # ----------------------------------------------------------------
     # This stage performs quality gates enforcements

eng/pipelines/templates/BuildAndTest.yml

@@ -31,6 +31,7 @@ steps:
 
   - script: ${{ parameters.buildScript }}
             -restore
+            -warnAsError ${{ parameters.warnAsError }}
             /bl:${{ parameters.repoLogPath }}/restore.binlog
     displayName: Restore
 
@@ -40,6 +41,7 @@ steps:
 
   - script: ${{ parameters.buildScript }}
             -restore
+            -warnAsError ${{ parameters.warnAsError }}
             /bl:${{ parameters.repoLogPath }}/restore2.binlog
     displayName: Restore solution
 
@@ -61,7 +63,7 @@ steps:
   - script: ${{ parameters.buildScript }}
             -pack
             -configuration ${{ parameters.buildConfig }}
-            -warnAsError 1
+            -warnAsError ${{ parameters.warnAsError }}
             /bl:${{ parameters.repoLogPath }}/pack.binlog
             /p:Restore=false /p:Build=false
             $(_OfficialBuildIdArgs)
@@ -71,7 +73,7 @@ steps:
     - script: ${{ parameters.buildScript }}
               -integrationTest
               -configuration ${{ parameters.buildConfig }}
-              -warnAsError 1
+              -warnAsError ${{ parameters.warnAsError }}
               /bl:${{ parameters.repoLogPath }}/integration_tests.binlog
               $(_OfficialBuildIdArgs)
       displayName: Run integration tests
@@ -158,6 +160,7 @@ steps:
     # Publishing will happen in a subsequent step
     - script: ${{ parameters.buildScript }}
               -projects $(Build.SourcesDirectory)/src/Packages/Microsoft.Internal.Extensions.DotNetApiDocs.Transport/Microsoft.Internal.Extensions.DotNetApiDocs.Transport.proj
+              -warnAsError ${{ parameters.warnAsError }}
               -pack
               -configuration ${{ parameters.buildConfig }}
               /bl:${{ parameters.repoLogPath }}/transport.binlog
@@ -173,7 +176,7 @@ steps:
               -sign $(_SignArgs)
               -publish $(_PublishArgs)
               -configuration ${{ parameters.buildConfig }}
-              -warnAsError 1
+              -warnAsError ${{ parameters.warnAsError }}
               /bl:${{ parameters.repoLogPath }}/publish.binlog
               /p:Build=false
               $(_OfficialBuildIdArgs)

test/Libraries/Microsoft.Extensions.DataIngestion.Tests/Microsoft.Extensions.DataIngestion.Tests.csproj

@@ -19,6 +19,11 @@
     <PackageReference Include="Microsoft.SemanticKernel.Connectors.SqliteVec" />
   </ItemGroup>
 
+  <ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
+    <!-- Workaround https://github.com/microsoft/semantic-kernel/issues/13316 -->
+    <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" VersionOverride="$(MicrosoftBclAsyncInterfacesVersion)" />
+  </ItemGroup>
+  
   <ItemGroup>
     <Compile Include="..\Microsoft.Extensions.AI.Abstractions.Tests\TestChatClient.cs" />
     <!-- We don't run Sqlite tests on Full Framework due to some native dependency issues -->