Implement DateOnly.DayNumber translations for SqlServer/Sqlite #36189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
added a commit
to roji/EntityFramework.Docs
that referenced
this pull request
Jun 5, 2025
roji
added a commit
to roji/EntityFramework.Docs
that referenced
this pull request
Jun 5, 2025
|
Doc PR: dotnet/EntityFramework.Docs#5042 |
cincuranet
reviewed
Jun 5, 2025
| instance | ||
| ], | ||
| nullable: true, | ||
| argumentsPropagateNullability: [false, true, true], |
There was a problem hiding this comment.
Shouldn't this be [false, false, true]?
There was a problem hiding this comment.
It could be - it doesn't matter either way, as the second argument is a non-null constant (and so the logic handling null semantics will do the right thing anyway). Up to now I've been generally specifying the function behavior in argumentsPropagateNullability, without taking the actual arguments into account - but let me know if you think we should do something else.
cincuranet
approved these changes
Jun 9, 2025
cincuranet
pushed a commit
to dotnet/EntityFramework.Docs
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to implement for Cosmos as well, but their DateTimeDiff function doesn't seem to work for timestamps before the year 1601 (and we need to calculate the number of days from
0001-01-01.Closes #36183