[release/8.0] Add missing parentheses for set operations #36139
Merged
+150
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cincuranet
approved these changes
May 26, 2025
|
Approved via email. |
This was referenced Jul 23, 2025
Closed
Closed
Closed
This was referenced Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #36110 (see #36138 for identical 9.0 backport PR)
Fixes #36105
Fixes #36112
Description
When generating SQL for multiple set operators (UNION, INTERSECT, EXCEPT), EF omitted adding parentheses in certain combinations, leading to the LINQ evaluation order not being preserved in the generated SQL. In addition, the SQLite provider didn't generate parentheses at all, since the SQLite syntax is non-standard and we originally thought no form of parentheses was possible.
Customer impact
The missing parentheses could cause the SQL set operators to be evaluated in an incorrect order (compared to the user's specified evaluation order in the LINQ query). This could lead to incorrect results getting returned from the database (data corruption).
How found
Reported by a user.
Regression
No
Testing
Added.
Risk
Very low. This is a minimal, targeted fix which only adds parentheses to preserve the LINQ evaluation order. A quirk was added just in case.