Make IQueryExpressionInterceptor an ISingletonInterceptor #36128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
QueryInterceptor
branch
2 times, most recently
from
eb4348d to
9b9aac6
Compare
roji
commented
May 23, 2025
| [InlineData(false, true)] | ||
| [InlineData(true, true)] | ||
| public virtual async Task Intercept_query_passively(bool async, bool inject) | ||
| [MemberData(nameof(IsAsyncData))] |
There was a problem hiding this comment.
@AndriySvyryd note that now that the interceptor is a singleton, we can't test "app interceptor" setup since the tests use an externally-provided internal service provider. It seems like the general interceptor machinery is already well-covered via other non-singleton interceptors that we can not also exercise it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36127
@AndriySvyryd am not too familiar with the IISingleInterceptor machinery, can you confirm this is the right approach?