Fix to #35983 - Cosmos/FTS: update translation of FullTextScore to use multiple keywords rather than keyword array #35984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
roji
reviewed
Apr 23, 2025
...EFCore.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.ParameterInliner.cs
Outdated
Show resolved
Hide resolved
…e multiple keywords rather than keyword array Reacting to Cosmos changing the signature of FullTextScore function. Fixes #35983
maumar
added a commit
that referenced
this pull request
Apr 25, 2025
…e multiple keywords rather than keyword array Port of #35984 Fixes #35983 Description Reacting to Cosmos changing the signature of FullTextScore function. Customer impact TBD How found Partner team ask. Regression No Testing Extensively tested on EF 10, manual testing on EF9. End-to-end testing is not possible because we can't create containers programmatically (no support for it inside EF Core itself, and the Cosmos SDK which supports it is currently only available in beta, so we can't take dependency on it). Instead, we created containers and data using EF 10, ported all the query tests from EF 10 and ran them using the EF9 bits. Partner team will conduct additional testing on their end. Risk Low. Localized change to translation - method signature exposed by EF is already in place. New translation now resembles other FullText methods, so same techniques can be used for translation (essentially re-using code that has been in place for other methods and working). Full text search support is experimental on EF9. Added quirk just in case.
roji
approved these changes
Apr 26, 2025
...EFCore.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.ParameterInliner.cs
Outdated
Show resolved
Hide resolved
…ressionVisitor.ParameterInliner.cs Co-authored-by: Shay Rojansky <roji@roji.org>
maumar
added a commit
that referenced
this pull request
May 12, 2025
…e multiple keywords rather than keyword array Port of #35984 Fixes #35983 Description Reacting to Cosmos changing the signature of FullTextScore function. Customer impact TBD How found Partner team ask. Regression No Testing Extensively tested on EF 10, manual testing on EF9. End-to-end testing is not possible because we can't create containers programmatically (no support for it inside EF Core itself, and the Cosmos SDK which supports it is currently only available in beta, so we can't take dependency on it). Instead, we created containers and data using EF 10, ported all the query tests from EF 10 and ran them using the EF9 bits. Partner team will conduct additional testing on their end. Risk Low. Localized change to translation - method signature exposed by EF is already in place. New translation now resembles other FullText methods, so same techniques can be used for translation (essentially re-using code that has been in place for other methods and working). Full text search support is experimental on EF9. Added quirk just in case.
maumar
added a commit
that referenced
this pull request
May 12, 2025
…e multiple keywords rather than keyword array (#36000) Port of #35984 Fixes #35983 Description Reacting to Cosmos changing the signature of FullTextScore function. Customer impact TBD How found Partner team ask. Regression No Testing Extensively tested on EF 10, manual testing on EF9. End-to-end testing is not possible because we can't create containers programmatically (no support for it inside EF Core itself, and the Cosmos SDK which supports it is currently only available in beta, so we can't take dependency on it). Instead, we created containers and data using EF 10, ported all the query tests from EF 10 and ran them using the EF9 bits. Partner team will conduct additional testing on their end. Risk Low. Localized change to translation - method signature exposed by EF is already in place. New translation now resembles other FullText methods, so same techniques can be used for translation (essentially re-using code that has been in place for other methods and working). Full text search support is experimental on EF9. Added quirk just in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reacting to Cosmos changing the signature of FullTextScore function.
Fixes #35983