-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[release/9.0] Fix TPC equality check inside subquery predicate (#35120) #35201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#35118 (cherry picked from commit 3d0b86d)
Approved via email |
ajcvickers
approved these changes
Nov 26, 2024
This was referenced Jul 22, 2025
This was referenced Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35118
Port of #35120
Description
The deep query pipeline re-architecting in 9.0 included turning our SQL expression tree into a real tree rather than a graph, i.e. removing cycles where a SQL table was referenced both from its containing SelectExpression, and from any referencing columns. As a result, a changed predicate check for TPC inheritance was broken and did not correctly access the column's table when the column was nested in a subquery and referenced an outer table.
Customer impact
LINQ queries including a minimal equality predicate where a column references an outer table are now broken. For example:
These queries are sufficiently common, and the fix sufficiently simple, that servicing seems justified.
How found
Customer reported on 9.0.0
Regression
Yes, from 8.0.
Testing
Test added.
Risk
Low, quirk added.