[release/9.0] Enable Cosmos vector search on EF9 #35183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @Pilchie |
ajcvickers
commented
Nov 22, 2024
Pilchie
approved these changes
Nov 22, 2024
ajcvickers
force-pushed
the
BringTheNoise
branch
from
b974cda to
216a0cf
Compare
roji
approved these changes
Nov 22, 2024
roji
changed the title
|
Servicing approved via email |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports #35074 to 9.0-staging.
Description
During the development of EF9, we worked with the Cosmos SDK folks to enable vector search against Cosmos DB using EF Core. This shipped in EF9, but we had to disable some functionality because it was not yet available in a non-preview Cosmos SDK. Cosmos have now released a public SDK, so this change updates EF9 to use these new APIs. The Cosmos folks have asked us to do this to make adoption of vector search easier for Cosmos customers.
Customer impact
Customers who want to try out vector search can use EF and the Cosmos emulator as an easy, low-friction way to get into vector search on Cosmos.
How found
N/A
Regression
No.
Testing
Existing tests enabled and passing.
Risk
Low.