[release/9.0] Generate correct calls for complex and primitive properties in the model snapshot#34587
Merged
Conversation
…del snapshot Fixes #34578
AndriySvyryd
force-pushed
the
Issue34578
branch
from
13d26c5 to
9138241
Compare
roji
approved these changes
Sep 1, 2024
artl93
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34578
Description
The model snapshot generated for migrations contains incorrect calls for primitive collections and extension methods on complex type properties.
Customer impact
Generated snapshot fails to compile and needs to be fixed manually each time it's generated.
How found
Reported by a user on 8.0.8
Regression
No, new feature in 8.0
Testing
Tests added.
Risk
Low. Only affects design-time