Expression bodies for query test base classes #26761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And other code cleanup that happened at the same time. First part of #26760
roji
approved these changes
Nov 19, 2021
| Shoes = { new() { Id = 13, Style = "Sneakers", Age = 19 }, new() { Id = 14, Style = "Dress", Age = 20 } } | ||
| Shoes = | ||
| { | ||
| new Shoes |
There was a problem hiding this comment.
Maybe leave this on single line, as long as it doesn't go over 120 I think cleanup leaves that alone
There was a problem hiding this comment.
There's nothing manual in this PR--it's all automatic cleanup. I can try to disable/change this rule if people think that's the right way to go.
There was a problem hiding this comment.
No problem for merging as-is from my side
|
Would like at least one of @smitpatel and @maumar to take a look before I go forward. (You're the ones who will be affected the most by this code. 😄) (Also, I still remember that time I got called into the Dev Lead's office and got a talking to when I merged code in their area without them signing off. 😉) |
maumar
approved these changes
Nov 19, 2021
|
no hiccups on my end either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And other code cleanup that happened at the same time.
First part of #26760