[6.0.1] Update the foreign key builder after IsRequired() #26719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Nov 17, 2021
ajcvickers
approved these changes
Nov 17, 2021
AndriySvyryd
changed the title
ajcvickers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26611
Description
When
IsRequired()is called for a foreign key specified on a shadow property we replace the property to change in to a non-nullable type. This invalidates the current reference held by the builder.Customer impact
All method calls after
IsRequired()for a foreign key specified on a shadow property will throw an exception. A workaround would involve separating these calls and repeating some of the setup.How found
Customer reported on 6.0
Regression
Yes, this worked in 5.0
Testing
Added test for this scenario.
Risk
Low, the fix is to update the foreign key reference held by the builder. Also added a quirk mode.