[6.0.1] Register design-time LoggerFactory as Scoped #26460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Oct 26, 2021
AndriySvyryd
changed the title
ajcvickers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26384
Description
Log messages produced by provider-specific services invoked by the EF CLI tools are no longer displayed.
Customer impact
There isn't a practical workaround as the reporter object is not accessible by the user.
How found
Customer report on RC2.
Regression
Yes, from 5.0, introduced in #25509
Testing
This PR changes tests to use DI to add coverage for this scenario.
Risk
Low; the fix only affects design-time logging. Quirk mode not added as there isn't a practical way to access
AppContextused by CLI tools.