[6.0] Fix to #26271 - Temporal history table name always based on entity type name, not table name #26281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pilchie for 6.0 approval. Low risk - changing temporal table naming pattern. Change is in the new feature and even if someone is using the RC version, we should just generate a simple history table rename (which we have tests for already) |
maumar
changed the title
ajcvickers
approved these changes
Oct 8, 2021
maumar
force-pushed
the
fix26271
branch
2 times, most recently
from
6898d78
to
52b407c
Compare
AndriySvyryd
reviewed
Oct 8, 2021
| @@ -3858,7 +3858,7 @@ public virtual async Task History_table_schema_not_created_if_we_know_it_already | |||
| [SystemTimeStart] datetime2 GENERATED ALWAYS AS ROW START HIDDEN NOT NULL, | |||
| CONSTRAINT [PK_Orders] PRIMARY KEY ([Id]), | |||
| PERIOD FOR SYSTEM_TIME([SystemTimeStart], [SystemTimeEnd]) | |||
| ) WITH (SYSTEM_VERSIONING = ON (HISTORY_TABLE = [mySchema].[OrderHistory]));"); | |||
| ) WITH (SYSTEM_VERSIONING = ON (HISTORY_TABLE = [mySchema].[OrdersHistory]));"); | |||
There was a problem hiding this comment.
Can you add a test for renaming just the history table?
There was a problem hiding this comment.
we already have it: Rename_history_table
AndriySvyryd
reviewed
Oct 8, 2021
src/EFCore.SqlServer/Extensions/SqlServerEntityTypeExtensions.cs
Outdated
Show resolved
Hide resolved
|
Approved for EFCore 6.0 GA. |
AndriySvyryd
approved these changes
Oct 8, 2021
…pe name, not table name When deciding on history table name use entityType.GetTableName() function instead of entity type name directly. Fixes #26271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deciding on history table name use entityType.GetTableName() function instead of entity type name directly.
Fixes #26271
Customer impact
No impact for customers starting with RTM. For customers who were using pre-release versions of EFCore and were using the feature and were using default name for history table, we will generate a migration (history table rename) that they will have to execute to fix the model.
How found
Validating and documenting new features in EF Core 6.0.
Regression
No.
Testing
Several functional tests execute the code path, as well as testing the migration path from pre-release to RTM (assuming it contains this fix)
Risk
Low. We are changing temporal table naming pattern.