[6.0] Query: Throw for FromSql+Any pattern which has been mutated #26211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
commented
Sep 29, 2021
smitpatel
force-pushed
the
smit/fromsql
branch
2 times, most recently
from
99a1895
to
033882e
Compare
AndriySvyryd
approved these changes
Sep 29, 2021
ajcvickers
approved these changes
Oct 4, 2021
|
@smitpatel Can we add tests that show that the workaround queries with Count work correctly? |
|
@Pilchie for 6.0. |
|
The scenario is approved for EFCore 6.0 GA, but please follow up on @ajcvickers comments in the PR before merging. |
smitpatel
force-pushed
the
smit/fromsql
branch
from
033882e
to
d2b4f91
Compare
|
Updated. |
smitpatel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #26167
Description
An exception is thrown for a certain pattern of raw SQL query that then uses
.Anyin LINQ. Fixing this for 6.0 is considered too risky, but we can detect when we're going to throw the exception, so we are making that exception more helpful. The workaround is to use.Countinstead, which is pretty easy once it is known.Customer impact
This is a relatively simple query, so we expect more customers to hit this. Helping them find the workaround will be useful.
How found
Customer reported.
Regression
Yes, in 6.0.
Testing
Tests added to make sure that the new exception is thrown.
Risk
Low. The fix just changes the exception thrown.