Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Remove excessive spaces from XML doc comments #26170

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

ajcvickers
Copy link
Member

No description provided.

@ajcvickers
Copy link
Member Author

@dotnet/efteam You asked for it! But now you have 1000 files to review. 🚎

@ajcvickers
Copy link
Member Author

@Pilchie FYI; changes XML docs only.

@ajcvickers ajcvickers requested a review from a team September 24, 2021 09:16
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but see the comment below

src/EFCore.Relational/Diagnostics/DbCommandInterceptor.cs Outdated Show resolved Hide resolved
@roji
Copy link
Member

roji commented Sep 24, 2021

BTW I think we also discussed un-indenting, so:

<summary>
    Foo
</summary>

would become:

<summary>
Foo
</summary>

@roji
Copy link
Member

roji commented Sep 24, 2021

@ajcvickers judging from the emoji positive/negative balance on the last comment, we should absolutely do this change!

On a more serious note though, this is how I'm generally used to it in .NET (e.g. https://github.com/dotnet/runtime/blob/main/src/libraries/System.Linq/src/System/Linq/IIListProvider.cs)

@ajcvickers
Copy link
Member Author

🐤 🌵 🍰 🗡️ 😮‍💨

I am the walrus.

@Pilchie
Copy link
Member

Pilchie commented Sep 24, 2021

Ok

@ajcvickers ajcvickers merged commit 289e7a6 into release/6.0 Sep 24, 2021
@ajcvickers ajcvickers deleted the SpacedOut0924 branch September 24, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants