Improve exception message for a shadow skip navigation #26128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pilchie For approval |
AndriySvyryd
force-pushed
the
Issue23362
branch
from
1c3a0b5
to
206e6eb
Compare
ajcvickers
approved these changes
Sep 22, 2021
|
Approved for EFCore 6.0 |
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23362
Description
Shadow skip navigations are not supported, but currently we don't explicitly validate this.
Customer impact
Without this an obscure
ArgumentExceptionis thrown when the navigation is used in a query.How found
Customer
Regression
No.
Testing
Test for this scenario added in the PR.
Risk
Low, just a better exception message.