Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0] Code cleanup on EFCore project #26100

Merged
merged 3 commits into from
Sep 23, 2021
Merged

[6.0] Code cleanup on EFCore project #26100

merged 3 commits into from
Sep 23, 2021

Conversation

ajcvickers
Copy link
Member

Supersedes #25350

@ajcvickers
Copy link
Member Author

@dotnet/efteam Don't review this at your peril! On the other hand, I know we're software "engineers", but please try not to be too pedantic. 😀

@Pilchie FYI; no functional changes. We want to do this before release to ease merging after patching.

@ajcvickers ajcvickers requested a review from a team September 18, 2021 09:11
AndriySvyryd
AndriySvyryd approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@ajcvickers ajcvickers changed the title Code cleanup on EFCore project [6.0] Code cleanup on EFCore project Sep 19, 2021
roji
roji approved these changes Sep 19, 2021
View reviewed changes
src/EFCore/ChangeTracking/Internal/Snapshot.cs Outdated Show resolved Hide resolved
src/EFCore/Infrastructure/ExpressionExtensions.cs Outdated Show resolved Hide resolved
src/EFCore/Internal/ServiceProviderCache.cs Show resolved Hide resolved
src/EFCore/Metadata/IEntityType.cs Outdated Show resolved Hide resolved
@Pilchie
Copy link
Member

Pilchie commented Sep 20, 2021

Ok I guess.

@bricelam
Copy link
Contributor

I ran dotnet format on this branch for fun, and it caught a lot more whitespace issues, but didn't seem to have any fundamental disagreements with these rules. I guess the real test would be to run R# again on top of that...

If you want to test it locally, change csharp_new_line_before_members_in_object_initializers to false first, it seems to cause some unnecessary changes.

@ajcvickers
Copy link
Member Author

@bricelam There were a few discrepancies after running R# again, but nothing major.

@ajcvickers ajcvickers merged commit 5e382f1 into release/6.0 Sep 23, 2021
@ajcvickers ajcvickers deleted the CleaninOutMyCloset0918 branch September 23, 2021 14:55
@ajcvickers ajcvickers mentioned this pull request Oct 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajcvickers @Pilchie @bricelam @roji @AndriySvyryd