Query: Use cancellationToken appropriately #25918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
reviewed
Sep 8, 2021
roji
approved these changes
Sep 8, 2021
|
@smitpatel I do agree you're raising an important thing here - I'd be happy to investigate if you can open an issue with a repro. |
|
I had written a test to repro, which didn't throw exception and ran query till end even though cancellation was requested. I tried to put same in stand-alone app, but didn't work exactly. (perhaps our test infra forces buffering in some way). The details for repro I think are captured above and the associated issue. May revisit later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #23652