Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MethodCallCodeFragment constructor accepting a chained call #25910

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

roji
Copy link
Member

@roji roji commented Sep 7, 2021

In 6.0 we added a MethodCallCodeFragment constructor when obsoleting the string-based APIs (for type-qualified calls) - this obsoletes it with error, since it's easy to accidentally call the other constructor which accepts params object[] arguments. I left it there with error so that anyone converting code would get a build error rather than resolving the wrong constructor.

Fixes #19780

@roji roji requested a review from a team September 7, 2021 20:11
@roji roji merged commit 0d18566 into release/6.0 Sep 8, 2021
@roji roji deleted the roji/Unchain branch September 8, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chained options for GenerateProviderOptions() throws error
2 participants