Cosmos: Escape invalid characters in the id value #25721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change the DateTime format to ISO 8601 Fixes #25100
roji
approved these changes
Aug 26, 2021
| if (propertyValue == null) | ||
| { | ||
| builder.Append("null"); | ||
| } else |
| var startingIndex = builder.Length; | ||
| return builder.Append(stringValue) | ||
| .Replace("|", "^|", startingIndex, builder.Length - startingIndex) | ||
| .Replace("/", "^2F", startingIndex, builder.Length - startingIndex) |
There was a problem hiding this comment.
I'm missing context, but why do the extra characters need to be escaped (I get that pipe is our custom separator within generated IDs, but the others)? Is there a specific reason for the choice of caret as the escape character?
There was a problem hiding this comment.
See https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.documents.resource.id?view=azure-dotnet for the list of invalid characters.
I've tried to URLEncode them, but it seems that the server decodes the values before storing them, so it still fails. Therefore I used the caret as an alternative encoding.
There was a problem hiding this comment.
All good, thanks for the info. A link in a comment could be helpful for future readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change the
DateTimeformat to ISO 8601Fixes #25100