Adding translations for cosmos string methods #25484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
force-pushed
the
cosmos_string_methods
branch
2 times, most recently
from
e9114aa
to
ff31f3d
Compare
smitpatel
reviewed
Aug 11, 2021
|
LENGTH is my adoption blocker |
maumar
force-pushed
the
cosmos_string_methods
branch
from
ff31f3d
to
1b86558
Compare
maumar
force-pushed
the
cosmos_string_methods
branch
from
1b86558
to
39a8df6
Compare
smitpatel
reviewed
Aug 12, 2021
smitpatel
reviewed
Aug 12, 2021
src/EFCore.SqlServer/Query/Internal/SqlServerStringMethodTranslator.cs
Outdated
Show resolved
Hide resolved
|
Any specific reason we are adding translations for VisualBasic.Strings class methods? Also if we decide to add, should split them out in separate class since it is not string method. |
|
vb got left and right methods so they map nicely to sql functions. |
maumar
force-pushed
the
cosmos_string_methods
branch
from
39a8df6
to
6162369
Compare
|
@smitpatel new version up |
smitpatel
approved these changes
Aug 12, 2021
INDEX_OF, REPLACE, case insensitive STRINGEQUALS
maumar
force-pushed
the
cosmos_string_methods
branch
from
6162369
to
9eb7116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INDEX_OF, LEFT, RIGHT, REPLACE, case insensitive STRINGEQUALS